Skip to content

chore: update swc build dependencies#28989

Merged
layershifter merged 1 commit into
microsoft:masterfrom
bsunderhus:swc/chore--update-build-dependencies
Aug 31, 2023
Merged

chore: update swc build dependencies#28989
layershifter merged 1 commit into
microsoft:masterfrom
bsunderhus:swc/chore--update-build-dependencies

Conversation

@bsunderhus

@bsunderhus bsunderhus commented Aug 25, 2023

Copy link
Copy Markdown
Contributor

Previous Behavior

New Behavior

updates swc dependencies:

  1. @swc/core -> "1.3.79"
  2. @swc/helpers -> "0.5.1"
  3. storybook-addon-swc -> "1.2.0"

Related Issue(s)

@bsunderhus bsunderhus self-assigned this Aug 25, 2023
@github-actions github-actions Bot added this to the August Project Cycle Q4 2023 milestone Aug 25, 2023
@codesandbox-ci

codesandbox-ci Bot commented Aug 25, 2023

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e1013db:

Sandbox Source
@fluentui/react 8 starter Configuration
@fluentui/react-components 9 starter Configuration

@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-components)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
Avatar mount 645 621 5000
Button mount 325 321 5000
Field mount 1151 1111 5000
FluentProvider mount 699 700 5000
FluentProviderWithTheme mount 83 90 10
FluentProviderWithTheme virtual-rerender 79 77 10
FluentProviderWithTheme virtual-rerender-with-unmount 77 78 10
InfoButton mount 10 14 5000
MakeStyles mount 857 858 50000
Persona mount 1763 1721 5000
SpinButton mount 1399 1370 5000

@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from 51da278 to c39f4f3 Compare August 25, 2023 13:23
@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

Package & Exports Baseline (minified/GZIP) PR Change
react-accordion
Accordion (including children components)
88.688 kB
26.917 kB
88.934 kB
26.969 kB
246 B
52 B
react-alert
Alert
81.668 kB
21.964 kB
82.011 kB
22.042 kB
343 B
78 B
react-avatar
Avatar
47.01 kB
14.502 kB
47.206 kB
14.562 kB
196 B
60 B
react-avatar
AvatarGroup
16.116 kB
6.431 kB
16.186 kB
6.457 kB
70 B
26 B
react-avatar
AvatarGroupItem
61.789 kB
18.912 kB
61.985 kB
18.974 kB
196 B
62 B
react-badge
Badge
23.183 kB
7.254 kB
23.253 kB
7.288 kB
70 B
34 B
react-badge
CounterBadge
24.084 kB
7.553 kB
24.154 kB
7.589 kB
70 B
36 B
react-badge
PresenceBadge
22.14 kB
7.867 kB
22.21 kB
7.9 kB
70 B
33 B
react-button
Button
36.91 kB
9.685 kB
37.127 kB
9.727 kB
217 B
42 B
react-button
CompoundButton
44.259 kB
11.167 kB
44.476 kB
11.225 kB
217 B
58 B
react-button
MenuButton
41.296 kB
10.933 kB
41.536 kB
10.992 kB
240 B
59 B
react-button
SplitButton
49.331 kB
12.486 kB
49.571 kB
12.548 kB
240 B
62 B
react-button
ToggleButton
53.956 kB
11.582 kB
54.215 kB
11.634 kB
259 B
52 B
react-card
Card - All
88.334 kB
25.252 kB
88.694 kB
25.317 kB
360 B
65 B
react-card
Card
83.177 kB
23.742 kB
83.495 kB
23.797 kB
318 B
55 B
react-card
CardFooter
9.338 kB
3.932 kB
9.408 kB
3.96 kB
70 B
28 B
react-card
CardHeader
11.589 kB
4.707 kB
11.701 kB
4.748 kB
112 B
41 B
react-card
CardPreview
10.297 kB
4.317 kB
10.367 kB
4.351 kB
70 B
34 B
react-checkbox
Checkbox
32.872 kB
10.652 kB
33.072 kB
10.727 kB
200 B
75 B
react-combobox
Combobox (including child components)
87.101 kB
28.273 kB
87.933 kB
28.539 kB
832 B
266 B
react-combobox
Dropdown (including child components)
85.555 kB
27.926 kB
86.278 kB
28.169 kB
723 B
243 B
react-components
react-components: Button, FluentProvider & webLightTheme
66.583 kB
18.469 kB
66.907 kB
18.548 kB
324 B
79 B
react-components
react-components: Accordion, Button, FluentProvider, Image, Menu, Popover
203.722 kB
57.915 kB
205.508 kB
58.347 kB
1.786 kB
432 B
react-components
react-components: FluentProvider & webLightTheme
37.926 kB
12.419 kB
38.103 kB
12.469 kB
177 B
50 B
react-datepicker-compat
DatePicker Compat
207.261 kB
57.469 kB
208.62 kB
57.77 kB
1.359 kB
301 B
react-dialog
Dialog (including children components)
87.129 kB
26.405 kB
87.504 kB
26.478 kB
375 B
73 B
react-divider
Divider
17.098 kB
6.303 kB
17.168 kB
6.327 kB
70 B
24 B
react-field
Field
18.295 kB
6.978 kB
18.466 kB
7.046 kB
171 B
68 B
react-image
Image
12.029 kB
4.783 kB
12.099 kB
4.808 kB
70 B
25 B
react-infobutton
InfoButton
125.517 kB
39.389 kB
126.751 kB
39.688 kB
1.234 kB
299 B
react-infobutton
InfoLabel
129.188 kB
40.559 kB
130.464 kB
40.865 kB
1.276 kB
306 B
react-input
Input
23.237 kB
7.688 kB
23.414 kB
7.759 kB
177 B
71 B
react-jsx-runtime
Classic Pragma
1.049 kB
531 B
1.072 kB
544 B
23 B
13 B
react-jsx-runtime
JSX Dev Runtime
2.752 kB
1.277 kB
2.775 kB
1.29 kB
23 B
13 B
react-jsx-runtime
JSX Runtime
3.27 kB
1.519 kB
3.293 kB
1.529 kB
23 B
10 B
react-label
Label
10.423 kB
4.31 kB
10.493 kB
4.334 kB
70 B
24 B
react-link
Link
13.254 kB
5.397 kB
13.37 kB
5.445 kB
116 B
48 B
react-menu
Menu (including children components)
135.626 kB
41.648 kB
136.96 kB
41.935 kB
1.334 kB
287 B
react-menu
Menu (including selectable components)
138.312 kB
42.154 kB
139.696 kB
42.47 kB
1.384 kB
316 B
react-overflow
hooks only
12.419 kB
4.687 kB
12.594 kB
4.702 kB
175 B
15 B
react-persona
Persona
53.905 kB
16.371 kB
54.101 kB
16.433 kB
196 B
62 B
react-popover
Popover
114.788 kB
36.02 kB
116.022 kB
36.301 kB
1.234 kB
281 B
react-portal
Portal
12.255 kB
4.504 kB
12.362 kB
4.543 kB
107 B
39 B
react-portal-compat
PortalCompatProvider
6.48 kB
2.203 kB
6.541 kB
2.227 kB
61 B
24 B
react-positioning
usePositioning
25.137 kB
9.109 kB
25.245 kB
9.141 kB
108 B
32 B
react-progress
ProgressBar
13.718 kB
5.476 kB
13.872 kB
5.539 kB
154 B
63 B
react-provider
FluentProvider
18.471 kB
6.847 kB
18.648 kB
6.899 kB
177 B
52 B
react-radio
Radio
26.617 kB
8.601 kB
26.784 kB
8.642 kB
167 B
41 B
react-radio
RadioGroup
11.622 kB
4.833 kB
11.814 kB
4.911 kB
192 B
78 B
react-select
Select
24.599 kB
8.651 kB
24.776 kB
8.731 kB
177 B
80 B
react-slider
Slider
34.134 kB
11.039 kB
34.311 kB
11.102 kB
177 B
63 B
react-spinbutton
SpinButton
32.773 kB
10.216 kB
32.992 kB
10.31 kB
219 B
94 B
react-spinner
Spinner
19.678 kB
7.03 kB
19.748 kB
7.055 kB
70 B
25 B
react-switch
Switch
29.092 kB
9.217 kB
29.343 kB
9.299 kB
251 B
82 B
react-table
DataGrid
152.991 kB
42.325 kB
154.174 kB
42.648 kB
1.183 kB
323 B
react-table
Table (Primitives only)
39.638 kB
12.129 kB
39.939 kB
12.198 kB
301 B
69 B
react-table
Table as DataGrid
126.247 kB
33.617 kB
126.91 kB
33.753 kB
663 B
136 B
react-table
Table (Selection only)
71.617 kB
18.915 kB
72.188 kB
19.062 kB
571 B
147 B
react-table
Table (Sort only)
70.236 kB
18.516 kB
70.819 kB
18.665 kB
583 B
149 B
react-tags-preview
InteractionTag
11.24 kB
4.54 kB
11.31 kB
4.567 kB
70 B
27 B
react-tags-preview
Tag
26.681 kB
8.419 kB
26.822 kB
8.462 kB
141 B
43 B
react-tags-preview
TagGroup
69.626 kB
20.485 kB
69.901 kB
20.555 kB
275 B
70 B
react-text
Text - Default
13.043 kB
5.129 kB
13.113 kB
5.151 kB
70 B
22 B
react-text
Text - Wrappers
16.215 kB
5.447 kB
16.285 kB
5.477 kB
70 B
30 B
react-textarea
Textarea
27.302 kB
9.047 kB
27.479 kB
9.12 kB
177 B
73 B
react-toast
Toast (including Toaster)
87.733 kB
26.042 kB
88.365 kB
26.188 kB
632 B
146 B
react-tooltip
Tooltip
48.1 kB
16.875 kB
48.593 kB
17.017 kB
493 B
142 B
Unchanged fixtures
Package & Exports Size (minified/GZIP)
global-context
createContext
510 B
330 B
global-context
createContextSelector
537 B
342 B
priority-overflow
createOverflowManager
4.162 kB
1.735 kB
react-theme
Single theme token import
69 B
89 B
react-theme
Teams: all themes
34.611 kB
7.295 kB
react-theme
Teams: Light theme
19.282 kB
5.486 kB
react-utilities
SSRProvider
180 B
159 B
🤖 This report was generated against e051b031c0b823f03c252ed59e329ade794b0686

@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react-northstar)

Perf tests with no regressions
Scenario Current PR Ticks Baseline Ticks Ratio
ChatWithPopoverPerf.default 213 193 1.1:1
AvatarMinimalPerf.default 112 105 1.07:1
TreeWith60ListItems.default 92 86 1.07:1
VideoMinimalPerf.default 430 406 1.06:1
AccordionMinimalPerf.default 89 85 1.05:1
AttachmentMinimalPerf.default 86 83 1.04:1
DropdownManyItemsPerf.default 409 393 1.04:1
ProviderMergeThemesPerf.default 702 677 1.04:1
BoxMinimalPerf.default 205 199 1.03:1
DropdownMinimalPerf.default 1471 1432 1.03:1
ImageMinimalPerf.default 223 217 1.03:1
ListNestedPerf.default 327 316 1.03:1
RefMinimalPerf.default 111 108 1.03:1
MenuButtonMinimalPerf.default 979 958 1.02:1
SplitButtonMinimalPerf.default 2272 2236 1.02:1
CardMinimalPerf.default 309 307 1.01:1
RosterPerf.default 1563 1543 1.01:1
SliderMinimalPerf.default 746 735 1.01:1
CheckboxMinimalPerf.default 1120 1118 1:1
DividerMinimalPerf.default 205 206 1:1
EmbedMinimalPerf.default 1895 1893 1:1
ItemLayoutMinimalPerf.default 709 706 1:1
MenuMinimalPerf.default 506 508 1:1
PortalMinimalPerf.default 86 86 1:1
ProviderMinimalPerf.default 201 201 1:1
ReactionMinimalPerf.default 224 224 1:1
IconMinimalPerf.default 396 396 1:1
TextAreaMinimalPerf.default 285 285 1:1
AlertMinimalPerf.default 149 150 0.99:1
AnimationMinimalPerf.default 301 304 0.99:1
ChatMinimalPerf.default 447 451 0.99:1
DatepickerMinimalPerf.default 3721 3756 0.99:1
DialogMinimalPerf.default 439 443 0.99:1
LabelMinimalPerf.default 218 221 0.99:1
ListMinimalPerf.default 313 316 0.99:1
ListWith60ListItems.default 363 367 0.99:1
CustomToolbarPrototype.default 1455 1477 0.99:1
TooltipMinimalPerf.default 1260 1269 0.99:1
TreeMinimalPerf.default 477 483 0.99:1
CarouselMinimalPerf.default 262 266 0.98:1
InputMinimalPerf.default 527 538 0.98:1
LayoutMinimalPerf.default 193 197 0.98:1
PopupMinimalPerf.default 349 355 0.98:1
ButtonOverridesMissPerf.default 648 665 0.97:1
ButtonSlotsPerf.default 322 331 0.97:1
GridMinimalPerf.default 192 197 0.97:1
HeaderMinimalPerf.default 207 214 0.97:1
HeaderSlotsPerf.default 465 481 0.97:1
RadioGroupMinimalPerf.default 265 273 0.97:1
ToolbarMinimalPerf.default 524 542 0.97:1
ButtonMinimalPerf.default 85 89 0.96:1
FlexMinimalPerf.default 156 164 0.95:1
FormMinimalPerf.default 213 224 0.95:1
TableManyItemsPerf.default 1142 1207 0.95:1
TableMinimalPerf.default 239 251 0.95:1
AttachmentSlotsPerf.default 628 668 0.94:1
ChatDuplicateMessagesPerf.default 150 160 0.94:1
SegmentMinimalPerf.default 195 207 0.94:1
TextMinimalPerf.default 190 202 0.94:1
StatusMinimalPerf.default 383 418 0.92:1
SkeletonMinimalPerf.default 195 216 0.9:1
ListCommonPerf.default 383 435 0.88:1
LoaderMinimalPerf.default 172 206 0.83:1

@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

🕵 FluentUIV0 No visual regressions between this PR and main

@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

Perf Analysis (@fluentui/react)

No significant results to display.

All results

Scenario Render type Master Ticks PR Ticks Iterations Status
BaseButton mount 647 637 5000
Breadcrumb mount 1660 1640 1000
Checkbox mount 1711 1661 5000
CheckboxBase mount 1498 1456 5000
ChoiceGroup mount 2957 2908 5000
ComboBox mount 650 654 1000
CommandBar mount 6173 6150 1000
ContextualMenu mount 12097 12149 1000
DefaultButton mount 772 752 5000
DetailsRow mount 2138 2171 5000
DetailsRowFast mount 2172 2149 5000
DetailsRowNoStyles mount 2011 1977 5000
Dialog mount 2785 2759 1000
DocumentCardTitle mount 223 232 1000
Dropdown mount 1990 1939 5000
FocusTrapZone mount 1127 1104 5000
FocusZone mount 1080 1106 5000
GroupedList mount 40948 41080 2
GroupedList virtual-rerender 17803 19604 2
GroupedList virtual-rerender-with-unmount 50394 50235 2
GroupedListV2 mount 217 221 2
GroupedListV2 virtual-rerender 218 216 2
GroupedListV2 virtual-rerender-with-unmount 227 228 2
IconButton mount 1095 1105 5000
Label mount 335 342 5000
Layer mount 2755 2699 5000
Link mount 387 385 5000
MenuButton mount 976 962 5000
MessageBar mount 21087 21182 5000
Nav mount 1938 1891 1000
OverflowSet mount 794 778 5000
Panel mount 1802 1762 1000
Persona mount 743 741 1000
Pivot mount 865 854 1000
PrimaryButton mount 851 858 5000
Rating mount 4673 4597 5000
SearchBox mount 915 911 5000
Shimmer mount 1853 1875 5000
Slider mount 1318 1325 5000
SpinButton mount 2853 2812 5000
Spinner mount 384 383 5000
SplitButton mount 1806 1841 5000
Stack mount 409 405 5000
StackWithIntrinsicChildren mount 869 853 5000
StackWithTextChildren mount 2617 2640 5000
SwatchColorPicker mount 6137 6002 5000
TagPicker mount 1461 1458 5000
Text mount 375 375 5000
TextField mount 949 920 5000
ThemeProvider mount 835 851 5000
ThemeProvider virtual-rerender 584 592 5000
ThemeProvider virtual-rerender-with-unmount 1304 1284 5000
Toggle mount 618 593 5000
buttonNative mount 209 195 5000

@size-auditor

size-auditor Bot commented Aug 25, 2023

Copy link
Copy Markdown

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: e051b031c0b823f03c252ed59e329ade794b0686 (build)

@fabricteam

fabricteam commented Aug 25, 2023

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv9 No visual regressions between this PR and main

@bsunderhus
bsunderhus marked this pull request as ready for review August 27, 2023 12:49
@bsunderhus
bsunderhus requested a review from a team as a code owner August 27, 2023 12:49
Comment thread package.json
@bsunderhus
bsunderhus requested a review from ling1726 August 28, 2023 09:02
@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from ae19fe8 to 980c230 Compare August 28, 2023 09:10
@bsunderhus
bsunderhus requested a review from a team as a code owner August 28, 2023 11:18
@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from 44019f6 to c3af323 Compare August 28, 2023 11:20
@YuanboXue-Amber

Copy link
Copy Markdown
Contributor

With this, we can remove the pin introduced by #28918 right?

@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from ffef0de to e502e50 Compare August 30, 2023 16:17

@marcosmoura marcosmoura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved for files owned by @microsoft/cxe-prg!

@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from e502e50 to 3a66d24 Compare August 31, 2023 07:08
@bsunderhus
bsunderhus force-pushed the swc/chore--update-build-dependencies branch from 3a66d24 to e1013db Compare August 31, 2023 09:35
@fabricteam

Copy link
Copy Markdown
Collaborator

🕵 fluentuiv8 No visual regressions between this PR and main

@layershifter
layershifter merged commit b93c2ac into microsoft:master Aug 31, 2023
@bsunderhus
bsunderhus deleted the swc/chore--update-build-dependencies branch August 31, 2023 12:09
@layershifter

Copy link
Copy Markdown
Member

We had enough approvals, CI was 🟢 , force merged to unblock.

marcosmoura added a commit to marcosmoura/fluentui that referenced this pull request Sep 3, 2023
* master: (32 commits)
  refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042)
  test(react-drawer): add render tests for drawer subcomponents (microsoft#29043)
  Grouped vertical bar chart - Component tests (microsoft#29031)
  docs: add Fluent UI Insights EP06 to README (microsoft#29051)
  chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040)
  chore: adds swc-plugin-de-indent-template-literal (microsoft#29037)
  feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
  chore: update swc build dependencies (microsoft#28989)
  fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035)
  chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024)
  chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022)
  chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016)
  applying package updates
  feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014)
  ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992)
  feat(react-drawer): add motion to Drawer (microsoft#28999)
  fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015)
  fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025)
  chore: updates devcontainer to use v16-bookworm image (microsoft#28997)
  feat(docsite): add Application Insights telemetry (microsoft#28709)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature]: Update @swc/helpers to 0.5.x

7 participants