chore: update swc build dependencies#28989
Merged
layershifter merged 1 commit intoAug 31, 2023
Merged
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e1013db:
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 645 | 621 | 5000 | |
| Button | mount | 325 | 321 | 5000 | |
| Field | mount | 1151 | 1111 | 5000 | |
| FluentProvider | mount | 699 | 700 | 5000 | |
| FluentProviderWithTheme | mount | 83 | 90 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 79 | 77 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 77 | 78 | 10 | |
| InfoButton | mount | 10 | 14 | 5000 | |
| MakeStyles | mount | 857 | 858 | 50000 | |
| Persona | mount | 1763 | 1721 | 5000 | |
| SpinButton | mount | 1399 | 1370 | 5000 |
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 25, 2023 13:23
51da278 to
c39f4f3
Compare
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ChatWithPopoverPerf.default | 213 | 193 | 1.1:1 |
| AvatarMinimalPerf.default | 112 | 105 | 1.07:1 |
| TreeWith60ListItems.default | 92 | 86 | 1.07:1 |
| VideoMinimalPerf.default | 430 | 406 | 1.06:1 |
| AccordionMinimalPerf.default | 89 | 85 | 1.05:1 |
| AttachmentMinimalPerf.default | 86 | 83 | 1.04:1 |
| DropdownManyItemsPerf.default | 409 | 393 | 1.04:1 |
| ProviderMergeThemesPerf.default | 702 | 677 | 1.04:1 |
| BoxMinimalPerf.default | 205 | 199 | 1.03:1 |
| DropdownMinimalPerf.default | 1471 | 1432 | 1.03:1 |
| ImageMinimalPerf.default | 223 | 217 | 1.03:1 |
| ListNestedPerf.default | 327 | 316 | 1.03:1 |
| RefMinimalPerf.default | 111 | 108 | 1.03:1 |
| MenuButtonMinimalPerf.default | 979 | 958 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2272 | 2236 | 1.02:1 |
| CardMinimalPerf.default | 309 | 307 | 1.01:1 |
| RosterPerf.default | 1563 | 1543 | 1.01:1 |
| SliderMinimalPerf.default | 746 | 735 | 1.01:1 |
| CheckboxMinimalPerf.default | 1120 | 1118 | 1:1 |
| DividerMinimalPerf.default | 205 | 206 | 1:1 |
| EmbedMinimalPerf.default | 1895 | 1893 | 1:1 |
| ItemLayoutMinimalPerf.default | 709 | 706 | 1:1 |
| MenuMinimalPerf.default | 506 | 508 | 1:1 |
| PortalMinimalPerf.default | 86 | 86 | 1:1 |
| ProviderMinimalPerf.default | 201 | 201 | 1:1 |
| ReactionMinimalPerf.default | 224 | 224 | 1:1 |
| IconMinimalPerf.default | 396 | 396 | 1:1 |
| TextAreaMinimalPerf.default | 285 | 285 | 1:1 |
| AlertMinimalPerf.default | 149 | 150 | 0.99:1 |
| AnimationMinimalPerf.default | 301 | 304 | 0.99:1 |
| ChatMinimalPerf.default | 447 | 451 | 0.99:1 |
| DatepickerMinimalPerf.default | 3721 | 3756 | 0.99:1 |
| DialogMinimalPerf.default | 439 | 443 | 0.99:1 |
| LabelMinimalPerf.default | 218 | 221 | 0.99:1 |
| ListMinimalPerf.default | 313 | 316 | 0.99:1 |
| ListWith60ListItems.default | 363 | 367 | 0.99:1 |
| CustomToolbarPrototype.default | 1455 | 1477 | 0.99:1 |
| TooltipMinimalPerf.default | 1260 | 1269 | 0.99:1 |
| TreeMinimalPerf.default | 477 | 483 | 0.99:1 |
| CarouselMinimalPerf.default | 262 | 266 | 0.98:1 |
| InputMinimalPerf.default | 527 | 538 | 0.98:1 |
| LayoutMinimalPerf.default | 193 | 197 | 0.98:1 |
| PopupMinimalPerf.default | 349 | 355 | 0.98:1 |
| ButtonOverridesMissPerf.default | 648 | 665 | 0.97:1 |
| ButtonSlotsPerf.default | 322 | 331 | 0.97:1 |
| GridMinimalPerf.default | 192 | 197 | 0.97:1 |
| HeaderMinimalPerf.default | 207 | 214 | 0.97:1 |
| HeaderSlotsPerf.default | 465 | 481 | 0.97:1 |
| RadioGroupMinimalPerf.default | 265 | 273 | 0.97:1 |
| ToolbarMinimalPerf.default | 524 | 542 | 0.97:1 |
| ButtonMinimalPerf.default | 85 | 89 | 0.96:1 |
| FlexMinimalPerf.default | 156 | 164 | 0.95:1 |
| FormMinimalPerf.default | 213 | 224 | 0.95:1 |
| TableManyItemsPerf.default | 1142 | 1207 | 0.95:1 |
| TableMinimalPerf.default | 239 | 251 | 0.95:1 |
| AttachmentSlotsPerf.default | 628 | 668 | 0.94:1 |
| ChatDuplicateMessagesPerf.default | 150 | 160 | 0.94:1 |
| SegmentMinimalPerf.default | 195 | 207 | 0.94:1 |
| TextMinimalPerf.default | 190 | 202 | 0.94:1 |
| StatusMinimalPerf.default | 383 | 418 | 0.92:1 |
| SkeletonMinimalPerf.default | 195 | 216 | 0.9:1 |
| ListCommonPerf.default | 383 | 435 | 0.88:1 |
| LoaderMinimalPerf.default | 172 | 206 | 0.83:1 |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 647 | 637 | 5000 | |
| Breadcrumb | mount | 1660 | 1640 | 1000 | |
| Checkbox | mount | 1711 | 1661 | 5000 | |
| CheckboxBase | mount | 1498 | 1456 | 5000 | |
| ChoiceGroup | mount | 2957 | 2908 | 5000 | |
| ComboBox | mount | 650 | 654 | 1000 | |
| CommandBar | mount | 6173 | 6150 | 1000 | |
| ContextualMenu | mount | 12097 | 12149 | 1000 | |
| DefaultButton | mount | 772 | 752 | 5000 | |
| DetailsRow | mount | 2138 | 2171 | 5000 | |
| DetailsRowFast | mount | 2172 | 2149 | 5000 | |
| DetailsRowNoStyles | mount | 2011 | 1977 | 5000 | |
| Dialog | mount | 2785 | 2759 | 1000 | |
| DocumentCardTitle | mount | 223 | 232 | 1000 | |
| Dropdown | mount | 1990 | 1939 | 5000 | |
| FocusTrapZone | mount | 1127 | 1104 | 5000 | |
| FocusZone | mount | 1080 | 1106 | 5000 | |
| GroupedList | mount | 40948 | 41080 | 2 | |
| GroupedList | virtual-rerender | 17803 | 19604 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50394 | 50235 | 2 | |
| GroupedListV2 | mount | 217 | 221 | 2 | |
| GroupedListV2 | virtual-rerender | 218 | 216 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 227 | 228 | 2 | |
| IconButton | mount | 1095 | 1105 | 5000 | |
| Label | mount | 335 | 342 | 5000 | |
| Layer | mount | 2755 | 2699 | 5000 | |
| Link | mount | 387 | 385 | 5000 | |
| MenuButton | mount | 976 | 962 | 5000 | |
| MessageBar | mount | 21087 | 21182 | 5000 | |
| Nav | mount | 1938 | 1891 | 1000 | |
| OverflowSet | mount | 794 | 778 | 5000 | |
| Panel | mount | 1802 | 1762 | 1000 | |
| Persona | mount | 743 | 741 | 1000 | |
| Pivot | mount | 865 | 854 | 1000 | |
| PrimaryButton | mount | 851 | 858 | 5000 | |
| Rating | mount | 4673 | 4597 | 5000 | |
| SearchBox | mount | 915 | 911 | 5000 | |
| Shimmer | mount | 1853 | 1875 | 5000 | |
| Slider | mount | 1318 | 1325 | 5000 | |
| SpinButton | mount | 2853 | 2812 | 5000 | |
| Spinner | mount | 384 | 383 | 5000 | |
| SplitButton | mount | 1806 | 1841 | 5000 | |
| Stack | mount | 409 | 405 | 5000 | |
| StackWithIntrinsicChildren | mount | 869 | 853 | 5000 | |
| StackWithTextChildren | mount | 2617 | 2640 | 5000 | |
| SwatchColorPicker | mount | 6137 | 6002 | 5000 | |
| TagPicker | mount | 1461 | 1458 | 5000 | |
| Text | mount | 375 | 375 | 5000 | |
| TextField | mount | 949 | 920 | 5000 | |
| ThemeProvider | mount | 835 | 851 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 592 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1304 | 1284 | 5000 | |
| Toggle | mount | 618 | 593 | 5000 | |
| buttonNative | mount | 209 | 195 | 5000 |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: e051b031c0b823f03c252ed59e329ade794b0686 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
marked this pull request as ready for review
August 27, 2023 12:49
ling1726
reviewed
Aug 28, 2023
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 28, 2023 09:02
c39f4f3 to
ae19fe8
Compare
bsunderhus
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
behowell,
chpalac,
khmakoto,
marcosmoura,
mltejera,
ms-acalzaretto,
sopranopillow and
tomi-msft
as code owners
August 28, 2023 09:02
bsunderhus
requested review from
a team,
micahgodbolt,
smhigley and
spmonahan
as code owners
August 28, 2023 09:02
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 28, 2023 09:10
ae19fe8 to
980c230
Compare
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 28, 2023 11:20
44019f6 to
c3af323
Compare
ling1726
approved these changes
Aug 29, 2023
Contributor
|
With this, we can remove the pin introduced by #28918 right? |
YuanboXue-Amber
approved these changes
Aug 29, 2023
TristanWatanabe
approved these changes
Aug 29, 2023
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 30, 2023 16:17
ffef0de to
e502e50
Compare
marcosmoura
approved these changes
Aug 30, 2023
marcosmoura
left a comment
Contributor
There was a problem hiding this comment.
Approved for files owned by @microsoft/cxe-prg!
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 31, 2023 07:08
e502e50 to
3a66d24
Compare
bsunderhus
force-pushed
the
swc/chore--update-build-dependencies
branch
from
August 31, 2023 09:35
3a66d24 to
e1013db
Compare
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
layershifter
approved these changes
Aug 31, 2023
Member
|
We had enough approvals, CI was 🟢 , force merged to unblock. |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 3, 2023
* master: (32 commits) refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042) test(react-drawer): add render tests for drawer subcomponents (microsoft#29043) Grouped vertical bar chart - Component tests (microsoft#29031) docs: add Fluent UI Insights EP06 to README (microsoft#29051) chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040) chore: adds swc-plugin-de-indent-template-literal (microsoft#29037) feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959) chore: update swc build dependencies (microsoft#28989) fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035) chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024) chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022) chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016) applying package updates feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014) ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992) feat(react-drawer): add motion to Drawer (microsoft#28999) fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015) fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025) chore: updates devcontainer to use v16-bookworm image (microsoft#28997) feat(docsite): add Application Insights telemetry (microsoft#28709) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Previous Behavior
New Behavior
updates swc dependencies:
@swc/core-> "1.3.79"@swc/helpers-> "0.5.1"storybook-addon-swc-> "1.2.0"Related Issue(s)