feat(react-jsx-runtime): v9 packages to use importSource#28959
Merged
layershifter merged 3 commits intoAug 31, 2023
Merged
Conversation
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
from
August 23, 2023 12:06
c1a8d06 to
3d44821
Compare
bsunderhus
changed the title
Collaborator
📊 Bundle size report
Unchanged fixtures
|
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
from
August 23, 2023 12:21
a4b4626 to
bdd7f3e
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 601 | 5000 | Possible regression |
| Button | mount | 309 | 309 | 5000 | Possible regression |
| SpinButton | mount | 1365 | 1334 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 601 | 5000 | Possible regression |
| Button | mount | 309 | 309 | 5000 | Possible regression |
| Field | mount | 1124 | 1120 | 5000 | |
| FluentProvider | mount | 698 | 705 | 5000 | |
| FluentProviderWithTheme | mount | 75 | 80 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 74 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 73 | 10 | |
| InfoButton | mount | 8 | 15 | 5000 | |
| MakeStyles | mount | 853 | 855 | 50000 | |
| Persona | mount | 1723 | 1710 | 5000 | |
| SpinButton | mount | 1365 | 1334 | 5000 | Possible regression |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4809681:
|
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
from
August 23, 2023 13:00
bdd7f3e to
4904656
Compare
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: b93c2ac22355b6cb6f33dd509c6cd9c21f4fffc8 (build) |
bsunderhus
marked this pull request as ready for review
August 23, 2023 13:52
bsunderhus
requested review from
a team,
GeoffCoxMSFT,
Mitch-At-Work,
behowell,
chpalac,
khmakoto,
ling1726,
micahgodbolt,
mltejera,
smhigley,
sopranopillow,
spmonahan and
tomi-msft
as code owners
August 23, 2023 13:52
ling1726
approved these changes
Aug 23, 2023
bsunderhus
requested review from
a team,
marcosmoura and
ms-acalzaretto
as code owners
August 28, 2023 09:49
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
from
August 28, 2023 09:51
e6f1f3d to
4c49b80
Compare
layershifter
approved these changes
Aug 28, 2023
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 240 | 217 | 1.11:1 |
| ProviderMinimalPerf.default | 216 | 197 | 1.1:1 |
| ChatWithPopoverPerf.default | 203 | 186 | 1.09:1 |
| PortalMinimalPerf.default | 94 | 86 | 1.09:1 |
| SegmentMinimalPerf.default | 205 | 192 | 1.07:1 |
| CardMinimalPerf.default | 321 | 307 | 1.05:1 |
| IconMinimalPerf.default | 377 | 361 | 1.04:1 |
| TextMinimalPerf.default | 194 | 186 | 1.04:1 |
| TreeWith60ListItems.default | 88 | 85 | 1.04:1 |
| VideoMinimalPerf.default | 450 | 432 | 1.04:1 |
| AnimationMinimalPerf.default | 300 | 291 | 1.03:1 |
| ButtonOverridesMissPerf.default | 645 | 633 | 1.02:1 |
| DialogMinimalPerf.default | 445 | 438 | 1.02:1 |
| DropdownManyItemsPerf.default | 389 | 381 | 1.02:1 |
| ReactionMinimalPerf.default | 221 | 217 | 1.02:1 |
| SplitButtonMinimalPerf.default | 2257 | 2222 | 1.02:1 |
| AccordionMinimalPerf.default | 79 | 78 | 1.01:1 |
| AvatarMinimalPerf.default | 102 | 101 | 1.01:1 |
| DatepickerMinimalPerf.default | 3637 | 3611 | 1.01:1 |
| InputMinimalPerf.default | 546 | 538 | 1.01:1 |
| ListMinimalPerf.default | 313 | 309 | 1.01:1 |
| LoaderMinimalPerf.default | 199 | 198 | 1.01:1 |
| PopupMinimalPerf.default | 379 | 375 | 1.01:1 |
| TreeMinimalPerf.default | 472 | 466 | 1.01:1 |
| ButtonMinimalPerf.default | 85 | 85 | 1:1 |
| CheckboxMinimalPerf.default | 1136 | 1133 | 1:1 |
| DividerMinimalPerf.default | 204 | 203 | 1:1 |
| FormMinimalPerf.default | 216 | 216 | 1:1 |
| HeaderMinimalPerf.default | 210 | 209 | 1:1 |
| HeaderSlotsPerf.default | 458 | 460 | 1:1 |
| LabelMinimalPerf.default | 218 | 218 | 1:1 |
| TableManyItemsPerf.default | 1069 | 1069 | 1:1 |
| AttachmentSlotsPerf.default | 658 | 664 | 0.99:1 |
| BoxMinimalPerf.default | 187 | 188 | 0.99:1 |
| ListWith60ListItems.default | 368 | 373 | 0.99:1 |
| SkeletonMinimalPerf.default | 194 | 195 | 0.99:1 |
| TableMinimalPerf.default | 229 | 231 | 0.99:1 |
| ToolbarMinimalPerf.default | 532 | 537 | 0.99:1 |
| AlertMinimalPerf.default | 157 | 161 | 0.98:1 |
| ButtonSlotsPerf.default | 308 | 313 | 0.98:1 |
| ChatMinimalPerf.default | 413 | 420 | 0.98:1 |
| DropdownMinimalPerf.default | 1414 | 1445 | 0.98:1 |
| EmbedMinimalPerf.default | 1852 | 1889 | 0.98:1 |
| ItemLayoutMinimalPerf.default | 691 | 705 | 0.98:1 |
| LayoutMinimalPerf.default | 195 | 199 | 0.98:1 |
| ListNestedPerf.default | 331 | 337 | 0.98:1 |
| MenuButtonMinimalPerf.default | 949 | 973 | 0.98:1 |
| ProviderMergeThemesPerf.default | 669 | 681 | 0.98:1 |
| SliderMinimalPerf.default | 715 | 727 | 0.98:1 |
| TextAreaMinimalPerf.default | 272 | 278 | 0.98:1 |
| CustomToolbarPrototype.default | 1454 | 1489 | 0.98:1 |
| CarouselMinimalPerf.default | 250 | 257 | 0.97:1 |
| MenuMinimalPerf.default | 495 | 512 | 0.97:1 |
| GridMinimalPerf.default | 177 | 185 | 0.96:1 |
| ListCommonPerf.default | 379 | 395 | 0.96:1 |
| RefMinimalPerf.default | 102 | 106 | 0.96:1 |
| TooltipMinimalPerf.default | 1264 | 1319 | 0.96:1 |
| FlexMinimalPerf.default | 150 | 158 | 0.95:1 |
| RosterPerf.default | 1597 | 1685 | 0.95:1 |
| ChatDuplicateMessagesPerf.default | 146 | 155 | 0.94:1 |
| StatusMinimalPerf.default | 374 | 404 | 0.93:1 |
| RadioGroupMinimalPerf.default | 253 | 286 | 0.88:1 |
| AttachmentMinimalPerf.default | 72 | 89 | 0.81:1 |
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 610 | 642 | 5000 | |
| Breadcrumb | mount | 1661 | 1675 | 1000 | |
| Checkbox | mount | 1671 | 1682 | 5000 | |
| CheckboxBase | mount | 1463 | 1461 | 5000 | |
| ChoiceGroup | mount | 2840 | 2919 | 5000 | |
| ComboBox | mount | 652 | 643 | 1000 | |
| CommandBar | mount | 6197 | 6251 | 1000 | |
| ContextualMenu | mount | 15523 | 14698 | 1000 | |
| DefaultButton | mount | 746 | 739 | 5000 | |
| DetailsRow | mount | 2184 | 2156 | 5000 | |
| DetailsRowFast | mount | 2127 | 2239 | 5000 | |
| DetailsRowNoStyles | mount | 2027 | 2001 | 5000 | |
| Dialog | mount | 2806 | 2700 | 1000 | |
| DocumentCardTitle | mount | 229 | 225 | 1000 | |
| Dropdown | mount | 1949 | 1950 | 5000 | |
| FocusTrapZone | mount | 1133 | 1136 | 5000 | |
| FocusZone | mount | 1082 | 1047 | 5000 | |
| GroupedList | mount | 41435 | 41870 | 2 | |
| GroupedList | virtual-rerender | 19842 | 19861 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52593 | 50676 | 2 | |
| GroupedListV2 | mount | 216 | 229 | 2 | |
| GroupedListV2 | virtual-rerender | 205 | 215 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 224 | 218 | 2 | |
| IconButton | mount | 1052 | 1089 | 5000 | |
| Label | mount | 332 | 332 | 5000 | |
| Layer | mount | 2671 | 2740 | 5000 | |
| Link | mount | 381 | 378 | 5000 | |
| MenuButton | mount | 918 | 914 | 5000 | |
| MessageBar | mount | 21106 | 21195 | 5000 | |
| Nav | mount | 1924 | 1886 | 1000 | |
| OverflowSet | mount | 758 | 767 | 5000 | |
| Panel | mount | 1778 | 1739 | 1000 | |
| Persona | mount | 736 | 753 | 1000 | |
| Pivot | mount | 864 | 848 | 1000 | |
| PrimaryButton | mount | 829 | 852 | 5000 | |
| Rating | mount | 4571 | 4606 | 5000 | |
| SearchBox | mount | 901 | 882 | 5000 | |
| Shimmer | mount | 1838 | 1806 | 5000 | |
| Slider | mount | 1328 | 1325 | 5000 | |
| SpinButton | mount | 2824 | 2877 | 5000 | |
| Spinner | mount | 383 | 378 | 5000 | |
| SplitButton | mount | 1810 | 1810 | 5000 | |
| Stack | mount | 412 | 401 | 5000 | |
| StackWithIntrinsicChildren | mount | 860 | 844 | 5000 | |
| StackWithTextChildren | mount | 2571 | 2578 | 5000 | |
| SwatchColorPicker | mount | 6214 | 6106 | 5000 | |
| TagPicker | mount | 1438 | 1424 | 5000 | |
| Text | mount | 369 | 373 | 5000 | |
| TextField | mount | 934 | 947 | 5000 | |
| ThemeProvider | mount | 821 | 842 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 577 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1295 | 1254 | 5000 | |
| Toggle | mount | 599 | 606 | 5000 | |
| buttonNative | mount | 187 | 198 | 5000 |
marcosmoura
approved these changes
Aug 28, 2023
marcosmoura
left a comment
marcosmoura
left a comment
Contributor
There was a problem hiding this comment.
Approved for files owned by @microsoft/cxe-prg!
sopranopillow
approved these changes
Aug 28, 2023
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
2 times, most recently
from
August 30, 2023 16:15
c382deb to
0e0a134
Compare
bsunderhus
force-pushed
the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
from
August 31, 2023 09:35
0e0a134 to
816fa4b
Compare
Member
|
We had enough approvals, CI was 🟢 , force merged to unblock. |
bsunderhus
deleted the
react-jsx-runtime/feat--v9-packages-to-use-importSource
branch
September 1, 2023 08:28
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 3, 2023
* master: refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042) test(react-drawer): add render tests for drawer subcomponents (microsoft#29043) Grouped vertical bar chart - Component tests (microsoft#29031) docs: add Fluent UI Insights EP06 to README (microsoft#29051) chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040) chore: adds swc-plugin-de-indent-template-literal (microsoft#29037) feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Sep 3, 2023
* master: (32 commits) refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042) test(react-drawer): add render tests for drawer subcomponents (microsoft#29043) Grouped vertical bar chart - Component tests (microsoft#29031) docs: add Fluent UI Insights EP06 to README (microsoft#29051) chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040) chore: adds swc-plugin-de-indent-template-literal (microsoft#29037) feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959) chore: update swc build dependencies (microsoft#28989) fix(react-tags-preview): add hover/pressed style for windows high contrast (microsoft#29035) chore(react-tags-preview): use InteractionTag for TagGroup's stories (microsoft#29024) chore(react-tags-preview): use makeResetStyles for base styles (microsoft#29022) chore: fix codesandbox export for preview component by making @fluentui/react-components required dependency (microsoft#29016) applying package updates feat(react-motion): create useReducedMotion and apply to useMotion to skip animations (microsoft#29014) ReAdd: Keytips: Align keytipData with visible instance for dupes (microsoft#28992) feat(react-drawer): add motion to Drawer (microsoft#28999) fix(react-utilities): avoid calling requestAnimationFrame when in SSR (microsoft#29015) fix(ssr-tests-v9): use correct path for ssr-tests-v9 stories (microsoft#29025) chore: updates devcontainer to use v16-bookworm image (microsoft#28997) feat(docsite): add Application Insights telemetry (microsoft#28709) ...
2 tasks
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@fluentui/react-jsx-runtimefeat: supports new automatic JSX runtime #28810peerDependenciesto comply with minimal react version requirement (v16.14.0)