test(react-drawer): add e2e for base drawer components#29029
Merged
marcosmoura merged 6 commits intoSep 5, 2023
Merged
Conversation
* master: feat(react-drawer): add motion to Drawer (microsoft#28999)
marcosmoura
commented
Aug 30, 2023
marcosmoura
commented
Aug 30, 2023
marcosmoura
commented
Aug 30, 2023
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 15 | 13 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 580 | 614 | 5000 | |
| Button | mount | 309 | 296 | 5000 | |
| Field | mount | 1086 | 1087 | 5000 | |
| FluentProvider | mount | 678 | 684 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 73 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 78 | 78 | 10 | |
| InfoButton | mount | 15 | 13 | 5000 | Possible regression |
| MakeStyles | mount | 848 | 843 | 50000 | |
| Persona | mount | 1682 | 1692 | 5000 | |
| SpinButton | mount | 1393 | 1382 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit b79b672:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 6363e77de4ed560ea8dbd53f5eb0511b65f19b77 (build) |
marcosmoura
enabled auto-merge (squash)
August 30, 2023 18:21
tudorpopams
self-requested a review
August 31, 2023 12:15
* master: refactor(react-drawer): change DrawerHeaderTitle slot creation while keeping the same API (microsoft#29042) test(react-drawer): add render tests for drawer subcomponents (microsoft#29043) Grouped vertical bar chart - Component tests (microsoft#29031) docs: add Fluent UI Insights EP06 to README (microsoft#29051) chore: use swc-plugin-de-indent-template-literal for consoles (microsoft#29040) chore: adds swc-plugin-de-indent-template-literal (microsoft#29037) feat(react-jsx-runtime): v9 packages to use importSource (microsoft#28959)
tudorpopams
approved these changes
Sep 5, 2023
marcosmoura
deleted the
test/add-e2e-tests-for-drawer-base-components
branch
September 5, 2023 14:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add missing Cypress tests for Drawer, DrawerInline and DrawerOverlay components.