chore(react-swatch-picker-preview): migrate from getNativeElementProps to getIntrinsicElementProps#29534
Merged
Conversation
…s to getIntrinsicElementProps
Collaborator
📊 Bundle size report🤖 This report was generated against 7dea38da7c75c481d8edf9b102eea8627078179d |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 80e556e:
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 7dea38da7c75c481d8edf9b102eea8627078179d (build) |
ValentinaKozlova
approved these changes
Oct 16, 2023
bsunderhus
enabled auto-merge (squash)
October 16, 2023 13:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
Follow up on #29310
getNativeElementPropshas some type safety issues, allowing erroneous properties to be introduced.getNativeElementPropswith an equivalent but more restrict methodgetIntrinsicElementProps