chore: deprecate getNativeElementProps in favor of getIntrinsicElementProps#29535
Merged
Conversation
Contributor
Author
|
blocked by #29534 |
bsunderhus
marked this pull request as ready for review
October 16, 2023 13:13
bsunderhus
marked this pull request as draft
October 16, 2023 13:14
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 614 | 650 | 5000 | |
| Button | mount | 307 | 320 | 5000 | |
| Field | mount | 1122 | 1092 | 5000 | |
| FluentProvider | mount | 697 | 730 | 5000 | |
| FluentProviderWithTheme | mount | 82 | 85 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 67 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 88 | 10 | |
| InfoButton | mount | 12 | 19 | 5000 | |
| MakeStyles | mount | 844 | 867 | 50000 | |
| Persona | mount | 1762 | 1725 | 5000 | |
| SpinButton | mount | 1390 | 1382 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 001c99e:
|
Collaborator
📊 Bundle size reportUnchanged fixtures
|
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 4f9b23d13eff25e9dc5f240b4bf607b7600b7c87 (build) |
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
bsunderhus
force-pushed
the
react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps
branch
2 times, most recently
from
October 16, 2023 13:49
869ca16 to
d5e8e60
Compare
bsunderhus
marked this pull request as ready for review
October 16, 2023 13:49
layershifter
approved these changes
Oct 16, 2023
bsunderhus
force-pushed
the
react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps
branch
from
October 16, 2023 14:11
d5e8e60 to
001c99e
Compare
ling1726
approved these changes
Oct 16, 2023
khmakoto
approved these changes
Oct 16, 2023
bsunderhus
deleted the
react-utilities/chore--deprecate-getNativeElementProps-in-favor-of-getIntrinsicElementProps
branch
October 17, 2023 12:27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
getNativeElementPropsin favor ofgetIntrinsicElementPropsgetIntrinsicElementPropsRelated Issue(s)