feat(scripts-storybook): make getMetadata throwable via config to be able to process stories glob for packages no longer present in the repo#31226
Merged
Hotell merged 2 commits intoMay 2, 2024
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Hotell
changed the title
Hotell
changed the title
Hotell
force-pushed
the
storybook/getPackageStoriesGlob-api-fixes
branch
from
April 30, 2024 10:48
50b8807 to
da65e4b
Compare
Hotell
marked this pull request as ready for review
April 30, 2024 10:51
tudorpopams
self-requested a review
April 30, 2024 11:13
Hotell
force-pushed
the
storybook/getPackageStoriesGlob-api-fixes
branch
from
April 30, 2024 13:10
da65e4b to
48ea588
Compare
…able to process stories glob for packages no longer present in the repo
Hotell
force-pushed
the
storybook/getPackageStoriesGlob-api-fixes
branch
from
April 30, 2024 16:07
48ea588 to
4d8e5f9
Compare
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
fabricteam
reviewed
Apr 30, 2024
Collaborator
🕵 fluentuiv9 No visual regressions between this PR and main |
marcosmoura
approved these changes
May 2, 2024
miroslavstastny
pushed a commit
to miroslavstastny/fluentui
that referenced
this pull request
Jun 14, 2024
…able to process stories glob for packages no longer present in the repo (microsoft#31226)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
getMetadatawill throw if dependency is not an workspace projectNew Behavior
getMetadatawill throw if dependency is not an workspace project only if explicitly set via new options API.getPackageStoriesGlobrefactored to use Array.reduce for perf and simpler logicRelated Issue(s)