fix(public-docsite-v9): disable storybook keyboard shortcuts#31762
Merged
dmytrokirpa merged 1 commit intoJun 24, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
dmytrokirpa
marked this pull request as ready for review
June 19, 2024 08:53
dmytrokirpa
requested review from
a team and
marcosmoura
and removed request for
marcosmoura
June 19, 2024 08:53
tudorpopams
approved these changes
Jun 20, 2024
dmytrokirpa
force-pushed
the
fix/disable_shortcuts_for_docsite
branch
from
June 21, 2024 15:03
a4dc463 to
9f8a416
Compare
spmonahan
approved these changes
Jun 21, 2024
dmytrokirpa
force-pushed
the
fix/disable_shortcuts_for_docsite
branch
from
June 22, 2024 07:48
9f8a416 to
682fa82
Compare
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 26, 2024
* master: (90 commits) fix(react-drawer): do not create global header/footer roles (microsoft#31799) release: applying package updates - react v8 release: applying package updates - web-components Add 'allowParentArrowNavigation' prop to `ComboBox`. (microsoft#31805) Add drawer web component (microsoft#31521) fix: MenuButton is styled correctly when aria-expanded is a string (microsoft#31809) chore: Updating version of `@fluentui/react-icons` to `^2.0.245` (microsoft#31802) chore:(docs) Migrate e2e Cypress testing doc (microsoft#31796) chore:(docs) Update API Extractor file (microsoft#31651) chore: migrate to nx 18 (microsoft#31746) release: applying package updates - react v8 release: applying package updates - web-components feat: update text to use element internals for custom states (microsoft#31770) chore(web-components): Remove define imports from story modules (microsoft#31622) fix(`merge-styles`): Correctly processing selectors when value is a class name and they are not wrapped in `selectors` wrapper (microsoft#31798) style(react-combobox): turn off react-compiler lints for non compliant code (microsoft#31795) docs: Add AriaLiveAnnouncer to all examples (microsoft#31794) fix(public-docsite-v9): disable storybook keyboard shortcuts (microsoft#31762) feat: V0 Attachment compact component (microsoft#31634) release: applying package updates - react v8 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Storybook platform uses
alt+downandalt+upto navigate between components. And that conflicts with the dropdown list keyboard shortcuts.New Behavior
The suggested solution is to disable Storybook's keyboard shortcuts to avoid conflicts with the existing components keyboard shortcuts.
Related Issue(s)