Add 'allowParentArrowNavigation' prop to ComboBox.#31805
Merged
Conversation
Allows parent controls like DetailsList to use arrow navigation with Comboboxes.
smhigley
approved these changes
Jun 24, 2024
Collaborator
📊 Bundle size report
Unchanged fixtures
|
fabricteam
reviewed
Jun 24, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 639 | 627 | 5000 | |
| Breadcrumb | mount | 1710 | 1659 | 1000 | |
| Checkbox | mount | 1734 | 1731 | 5000 | |
| CheckboxBase | mount | 1503 | 1503 | 5000 | |
| ChoiceGroup | mount | 2999 | 2953 | 5000 | |
| ComboBox | mount | 680 | 688 | 1000 | |
| CommandBar | mount | 6627 | 6607 | 1000 | |
| ContextualMenu | mount | 13081 | 13248 | 1000 | |
| DefaultButton | mount | 816 | 808 | 5000 | |
| DetailsRow | mount | 2280 | 2224 | 5000 | |
| DetailsRowFast | mount | 2230 | 2215 | 5000 | |
| DetailsRowNoStyles | mount | 2047 | 2091 | 5000 | |
| Dialog | mount | 2707 | 2620 | 1000 | |
| DocumentCardTitle | mount | 221 | 234 | 1000 | |
| Dropdown | mount | 2024 | 2037 | 5000 | |
| FocusTrapZone | mount | 1163 | 1151 | 5000 | |
| FocusZone | mount | 1090 | 1091 | 5000 | |
| GroupedList | mount | 38197 | 42582 | 2 | |
| GroupedList | virtual-rerender | 20208 | 20426 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 51821 | 51321 | 2 | |
| GroupedListV2 | mount | 230 | 232 | 2 | |
| GroupedListV2 | virtual-rerender | 206 | 214 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 225 | 231 | 2 | |
| IconButton | mount | 1145 | 1130 | 5000 | |
| Label | mount | 340 | 350 | 5000 | |
| Layer | mount | 2779 | 2814 | 5000 | |
| Link | mount | 411 | 394 | 5000 | |
| MenuButton | mount | 959 | 1008 | 5000 | |
| MessageBar | mount | 21881 | 21826 | 5000 | |
| Nav | mount | 2046 | 2023 | 1000 | |
| OverflowSet | mount | 798 | 782 | 5000 | |
| Panel | mount | 1844 | 1818 | 1000 | |
| Persona | mount | 767 | 736 | 1000 | |
| Pivot | mount | 893 | 907 | 1000 | |
| PrimaryButton | mount | 937 | 945 | 5000 | |
| Rating | mount | 4772 | 4658 | 5000 | |
| SearchBox | mount | 934 | 935 | 5000 | |
| Shimmer | mount | 1902 | 1905 | 5000 | |
| Slider | mount | 1370 | 1351 | 5000 | |
| SpinButton | mount | 2981 | 2999 | 5000 | |
| Spinner | mount | 400 | 395 | 5000 | |
| SplitButton | mount | 1915 | 1860 | 5000 | |
| Stack | mount | 422 | 435 | 5000 | |
| StackWithIntrinsicChildren | mount | 854 | 866 | 5000 | |
| StackWithTextChildren | mount | 2793 | 2775 | 5000 | |
| SwatchColorPicker | mount | 6449 | 6429 | 5000 | |
| TagPicker | mount | 1473 | 1450 | 5000 | |
| Text | mount | 379 | 375 | 5000 | |
| TextField | mount | 943 | 977 | 5000 | |
| ThemeProvider | mount | 857 | 856 | 5000 | |
| ThemeProvider | virtual-rerender | 584 | 588 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1289 | 1333 | 5000 | |
| Toggle | mount | 626 | 606 | 5000 | |
| buttonNative | mount | 191 | 188 | 5000 |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jun 26, 2024
* master: (90 commits) fix(react-drawer): do not create global header/footer roles (microsoft#31799) release: applying package updates - react v8 release: applying package updates - web-components Add 'allowParentArrowNavigation' prop to `ComboBox`. (microsoft#31805) Add drawer web component (microsoft#31521) fix: MenuButton is styled correctly when aria-expanded is a string (microsoft#31809) chore: Updating version of `@fluentui/react-icons` to `^2.0.245` (microsoft#31802) chore:(docs) Migrate e2e Cypress testing doc (microsoft#31796) chore:(docs) Update API Extractor file (microsoft#31651) chore: migrate to nx 18 (microsoft#31746) release: applying package updates - react v8 release: applying package updates - web-components feat: update text to use element internals for custom states (microsoft#31770) chore(web-components): Remove define imports from story modules (microsoft#31622) fix(`merge-styles`): Correctly processing selectors when value is a class name and they are not wrapped in `selectors` wrapper (microsoft#31798) style(react-combobox): turn off react-compiler lints for non compliant code (microsoft#31795) docs: Add AriaLiveAnnouncer to all examples (microsoft#31794) fix(public-docsite-v9): disable storybook keyboard shortcuts (microsoft#31762) feat: V0 Attachment compact component (microsoft#31634) release: applying package updates - react v8 ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
When using
ComboBoxinsideDetailsListarrow navigation would get stuck onComboBox. This is because the code would hit this break and then callstopPropagation()andpreventDefault()on the keyboard event, preventing navigation.New Behavior
This PR introduces a new prop allowing users to opt in to a behavior that will skip the calls to
stopPropagation()andpreventDefault().Related Issue(s)