Skip to content

chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule #32072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bsunderhus merged 1 commit into from
Jul 23, 2024
Merged

chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule #32072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-eslint-plugin-c622c77c-61e2-4433-b4cf-da2ad0984040.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
Comment thread
bsunderhus marked this conversation as resolved.
"type": "patch",
"comment": "chore: removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element",
"packageName": "@fluentui/eslint-plugin",
"email": "bernardo.sunderhus@gmail.com",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@fluentui-react-utilities-8376a788-0cd7-4976-b302-c88844a11938.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "chore: stops leaking HTMLElementConstructorName type",
"packageName": "@fluentui/react-utilities",
"email": "bernardo.sunderhus@gmail.com",
"dependentChangeType": "patch"
}
3 changes: 1 addition & 2 deletions packages/eslint-plugin/src/rules/ban-instanceof-html-element/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const { AST_NODE_TYPES } = require('@typescript-eslint/utils');
const createRule = require('../../utils/createRule');

/**
* @typedef {import("@fluentui/react-utilities/src/utils/isHTMLElement").HTMLElementConstructorName} HTMLElementConstructorName
* @typedef {import('./types').HTMLElementConstructorName} HTMLElementConstructorName
*
*/

Expand Down Expand Up @@ -56,7 +56,6 @@ const constructorNames = [
'HTMLDataElement',
'HTMLDataListElement',
'HTMLDetailsElement',
// @ts-expect-error - NOTE: dialog is not supported in safari 14, also it was removed from lib-dom starting typescript 4.4
'HTMLDialogElement',
'HTMLDivElement',
'HTMLDListElement',
Expand Down
64 changes: 64 additions & 0 deletions packages/eslint-plugin/src/rules/ban-instanceof-html-element/types.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,64 @@
/**
* All the possible HTML element constructor names.
*/
export type HTMLElementConstructorName =
| 'HTMLElement'
| 'HTMLAnchorElement'
| 'HTMLAreaElement'
| 'HTMLAudioElement'
| 'HTMLBaseElement'
| 'HTMLBodyElement'
| 'HTMLBRElement'
| 'HTMLButtonElement'
| 'HTMLCanvasElement'
| 'HTMLDataElement'
| 'HTMLDataListElement'
| 'HTMLDetailsElement'
| 'HTMLDialogElement'
| 'HTMLDivElement'
| 'HTMLDListElement'
| 'HTMLEmbedElement'
| 'HTMLFieldSetElement'
| 'HTMLFormElement'
| 'HTMLHeadingElement'
| 'HTMLHeadElement'
| 'HTMLHRElement'
| 'HTMLHtmlElement'
| 'HTMLIFrameElement'
| 'HTMLImageElement'
| 'HTMLInputElement'
| 'HTMLModElement'
| 'HTMLLabelElement'
| 'HTMLLegendElement'
| 'HTMLLIElement'
| 'HTMLLinkElement'
| 'HTMLMapElement'
| 'HTMLMetaElement'
| 'HTMLMeterElement'
| 'HTMLObjectElement'
| 'HTMLOListElement'
| 'HTMLOptGroupElement'
| 'HTMLOptionElement'
| 'HTMLOutputElement'
| 'HTMLParagraphElement'
| 'HTMLParamElement'
| 'HTMLPreElement'
| 'HTMLProgressElement'
| 'HTMLQuoteElement'
| 'HTMLSlotElement'
| 'HTMLScriptElement'
| 'HTMLSelectElement'
| 'HTMLSourceElement'
| 'HTMLSpanElement'
| 'HTMLStyleElement'
| 'HTMLTableElement'
| 'HTMLTableColElement'
| 'HTMLTableRowElement'
| 'HTMLTableSectionElement'
| 'HTMLTemplateElement'
| 'HTMLTextAreaElement'
| 'HTMLTimeElement'
| 'HTMLTitleElement'
| 'HTMLTrackElement'
| 'HTMLUListElement'
| 'HTMLVideoElement';
5 changes: 1 addition & 4 deletions packages/react-components/react-utilities/src/utils/isHTMLElement.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,7 @@ export function isHTMLElement<ConstructorName extends HTMLElementConstructorName
);
}

/**
* @internal
*/
export type HTMLElementConstructorName =
type HTMLElementConstructorName =
| 'HTMLElement'
| 'HTMLAnchorElement'
| 'HTMLAreaElement'
Expand Down