chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule#32072
Merged
Conversation
…ities internals in ban-instanceof-html-element rule
Collaborator
🕵 fluentui-web-components-v3 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 648 | 624 | 5000 | |
| Button | mount | 289 | 302 | 5000 | |
| Field | mount | 1140 | 1105 | 5000 | |
| FluentProvider | mount | 694 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 86 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 37 | 31 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 80 | 71 | 10 | |
| MakeStyles | mount | 861 | 862 | 50000 | |
| Persona | mount | 1755 | 1744 | 5000 | |
| SpinButton | mount | 1413 | 1405 | 5000 | |
| SwatchPicker | mount | 1656 | 1655 | 5000 |
Collaborator
📊 Bundle size report
Unchanged fixtures
|
Collaborator
🕵 fluentuiv8 No visual regressions between this PR and main |
Collaborator
🕵 FluentUIV0 No visual regressions between this PR and main |
Collaborator
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio | Regression Analysis |
|---|---|---|---|---|
| AttachmentMinimalPerf.default | 76 | 83 | 0.92:1 | analysis |
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| AvatarMinimalPerf.default | 116 | 102 | 1.14:1 |
| TreeWith60ListItems.default | 93 | 83 | 1.12:1 |
| ImageMinimalPerf.default | 243 | 221 | 1.1:1 |
| DialogMinimalPerf.default | 469 | 434 | 1.08:1 |
| SegmentMinimalPerf.default | 211 | 195 | 1.08:1 |
| SkeletonMinimalPerf.default | 210 | 194 | 1.08:1 |
| CarouselMinimalPerf.default | 271 | 254 | 1.07:1 |
| ProviderMinimalPerf.default | 208 | 195 | 1.07:1 |
| RefMinimalPerf.default | 117 | 109 | 1.07:1 |
| BoxMinimalPerf.default | 201 | 189 | 1.06:1 |
| ToolbarMinimalPerf.default | 556 | 525 | 1.06:1 |
| LabelMinimalPerf.default | 230 | 220 | 1.05:1 |
| RadioGroupMinimalPerf.default | 280 | 266 | 1.05:1 |
| ReactionMinimalPerf.default | 215 | 205 | 1.05:1 |
| AccordionMinimalPerf.default | 86 | 83 | 1.04:1 |
| ButtonMinimalPerf.default | 94 | 90 | 1.04:1 |
| DividerMinimalPerf.default | 215 | 206 | 1.04:1 |
| HeaderSlotsPerf.default | 468 | 449 | 1.04:1 |
| ItemLayoutMinimalPerf.default | 721 | 692 | 1.04:1 |
| PortalMinimalPerf.default | 87 | 84 | 1.04:1 |
| TableMinimalPerf.default | 235 | 225 | 1.04:1 |
| VideoMinimalPerf.default | 439 | 421 | 1.04:1 |
| AttachmentSlotsPerf.default | 670 | 649 | 1.03:1 |
| FormMinimalPerf.default | 220 | 214 | 1.03:1 |
| AnimationMinimalPerf.default | 304 | 297 | 1.02:1 |
| ButtonSlotsPerf.default | 319 | 312 | 1.02:1 |
| ChatMinimalPerf.default | 449 | 440 | 1.02:1 |
| DropdownMinimalPerf.default | 1435 | 1411 | 1.02:1 |
| EmbedMinimalPerf.default | 1918 | 1882 | 1.02:1 |
| ListCommonPerf.default | 392 | 386 | 1.02:1 |
| StatusMinimalPerf.default | 396 | 388 | 1.02:1 |
| IconMinimalPerf.default | 384 | 378 | 1.02:1 |
| TextMinimalPerf.default | 196 | 192 | 1.02:1 |
| TextAreaMinimalPerf.default | 293 | 287 | 1.02:1 |
| AlertMinimalPerf.default | 159 | 158 | 1.01:1 |
| DatepickerMinimalPerf.default | 3612 | 3585 | 1.01:1 |
| GridMinimalPerf.default | 191 | 189 | 1.01:1 |
| InputMinimalPerf.default | 547 | 540 | 1.01:1 |
| MenuMinimalPerf.default | 518 | 511 | 1.01:1 |
| CustomToolbarPrototype.default | 1472 | 1460 | 1.01:1 |
| ChatWithPopoverPerf.default | 205 | 204 | 1:1 |
| CheckboxMinimalPerf.default | 1139 | 1141 | 1:1 |
| MenuButtonMinimalPerf.default | 950 | 951 | 1:1 |
| TableManyItemsPerf.default | 1102 | 1104 | 1:1 |
| TooltipMinimalPerf.default | 1241 | 1242 | 1:1 |
| ButtonOverridesMissPerf.default | 669 | 677 | 0.99:1 |
| HeaderMinimalPerf.default | 206 | 209 | 0.99:1 |
| ListMinimalPerf.default | 298 | 300 | 0.99:1 |
| PopupMinimalPerf.default | 350 | 353 | 0.99:1 |
| ProviderMergeThemesPerf.default | 649 | 653 | 0.99:1 |
| SliderMinimalPerf.default | 737 | 744 | 0.99:1 |
| SplitButtonMinimalPerf.default | 2286 | 2304 | 0.99:1 |
| ListNestedPerf.default | 321 | 328 | 0.98:1 |
| ListWith60ListItems.default | 377 | 386 | 0.98:1 |
| LoaderMinimalPerf.default | 194 | 197 | 0.98:1 |
| RosterPerf.default | 1588 | 1618 | 0.98:1 |
| CardMinimalPerf.default | 306 | 315 | 0.97:1 |
| DropdownManyItemsPerf.default | 381 | 391 | 0.97:1 |
| TreeMinimalPerf.default | 489 | 502 | 0.97:1 |
| FlexMinimalPerf.default | 159 | 168 | 0.95:1 |
| LayoutMinimalPerf.default | 197 | 207 | 0.95:1 |
| ChatDuplicateMessagesPerf.default | 144 | 154 | 0.94:1 |
fabricteam
reviewed
Jul 23, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 635 | 654 | 5000 | |
| Breadcrumb | mount | 1685 | 1700 | 1000 | |
| Checkbox | mount | 1677 | 1704 | 5000 | |
| CheckboxBase | mount | 1475 | 1476 | 5000 | |
| ChoiceGroup | mount | 2956 | 2977 | 5000 | |
| ComboBox | mount | 676 | 685 | 1000 | |
| CommandBar | mount | 6607 | 6600 | 1000 | |
| ContextualMenu | mount | 13676 | 14751 | 1000 | |
| DefaultButton | mount | 791 | 795 | 5000 | |
| DetailsRow | mount | 2255 | 2213 | 5000 | |
| DetailsRowFast | mount | 2184 | 2230 | 5000 | |
| DetailsRowNoStyles | mount | 2028 | 2054 | 5000 | |
| Dialog | mount | 2833 | 2684 | 1000 | |
| DocumentCardTitle | mount | 230 | 236 | 1000 | |
| Dropdown | mount | 1973 | 2020 | 5000 | |
| FocusTrapZone | mount | 1116 | 1145 | 5000 | |
| FocusZone | mount | 1076 | 1103 | 5000 | |
| GroupedList | mount | 42373 | 42344 | 2 | |
| GroupedList | virtual-rerender | 20412 | 20473 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 52590 | 51912 | 2 | |
| GroupedListV2 | mount | 229 | 233 | 2 | |
| GroupedListV2 | virtual-rerender | 214 | 219 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 232 | 232 | 2 | |
| IconButton | mount | 1138 | 1156 | 5000 | |
| Label | mount | 343 | 343 | 5000 | |
| Layer | mount | 2743 | 2759 | 5000 | |
| Link | mount | 405 | 407 | 5000 | |
| MenuButton | mount | 987 | 955 | 5000 | |
| MessageBar | mount | 21398 | 21389 | 5000 | |
| Nav | mount | 2033 | 2040 | 1000 | |
| OverflowSet | mount | 810 | 801 | 5000 | |
| Panel | mount | 1835 | 1798 | 1000 | |
| Persona | mount | 747 | 766 | 1000 | |
| Pivot | mount | 915 | 905 | 1000 | |
| PrimaryButton | mount | 911 | 925 | 5000 | |
| Rating | mount | 4632 | 4673 | 5000 | |
| SearchBox | mount | 903 | 912 | 5000 | |
| Shimmer | mount | 1915 | 1912 | 5000 | |
| Slider | mount | 1342 | 1366 | 5000 | |
| SpinButton | mount | 2990 | 3025 | 5000 | |
| Spinner | mount | 396 | 388 | 5000 | |
| SplitButton | mount | 1893 | 1901 | 5000 | |
| Stack | mount | 416 | 435 | 5000 | |
| StackWithIntrinsicChildren | mount | 860 | 870 | 5000 | |
| StackWithTextChildren | mount | 2769 | 2779 | 5000 | |
| SwatchColorPicker | mount | 6457 | 6378 | 5000 | |
| TagPicker | mount | 1531 | 1491 | 5000 | |
| Text | mount | 389 | 382 | 5000 | |
| TextField | mount | 960 | 954 | 5000 | |
| ThemeProvider | mount | 878 | 841 | 5000 | |
| ThemeProvider | virtual-rerender | 578 | 601 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1325 | 1308 | 5000 | |
| Toggle | mount | 632 | 606 | 5000 | |
| buttonNative | mount | 199 | 199 | 5000 |
bsunderhus
marked this pull request as ready for review
July 23, 2024 08:08
mainframev
approved these changes
Jul 23, 2024
mainframev
left a comment
mainframev
left a comment
Contributor
There was a problem hiding this comment.
Thanks for quick reaction on this! @bsunderhus 🚀
ling1726
approved these changes
Jul 23, 2024
bsunderhus
deleted the
react-utilities/chore--removes-type-dependency-on-@fluentui/react-utilities-internals
branch
July 23, 2024 08:39
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Jul 25, 2024
* master: (77 commits) chore(react-examples): replace storybook deprecated api with static stories (microsoft#32074) [chore]: create base class for accordion item and remove style and layout specific api (microsoft#32102) release: applying package updates - web-components chore(web-components): add test for complex focus management (microsoft#32009) [chore]: create base class for avatar and remove style and layout specific api (microsoft#32083) [chore]: create base class for text input and remove style and layout specific api (microsoft#32080) release: applying package updates - web-components chore:(react-nav-preview) Scaffold AppItem (microsoft#32088) docs(`react-teaching-popover`): Adding subcomponents' API to `TeachingPopover` documentation page (microsoft#32084) feat(web-components): relax setTheme() argument type to allow custom tokens (microsoft#32087) release: applying package updates - react-components [Chore]: Create Spinner base class to abstract out style and layout specific api. (microsoft#32067) [Chore]: Create Progress Bar base class to abstract out style and layout specific api. (microsoft#32066) fix(react-storybook-addon): transform decorator to function in withAriaLive() (microsoft#32011) fix(motion): improve Web Animations API detection in tests (microsoft#32029) chore(eslint-plugin): removes type dependency on @fluentui/react-utilities internals in ban-instanceof-html-element rule (microsoft#32072) release: applying package updates - react v8 release: applying package updates - web-components Chore: Create Divider base class to abstract out style and layout specific api (microsoft#32065) fix(TimePicker): Clear text when date value changes to null (microsoft#31626) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
New Behavior
"@fluentui/react-utilities/src/utils/isHTMLElement"file fromban-instanceof-html-elementeslint ruleRelated Issue(s)