feat(motion): add collapse motion for Accordion#32086
Merged
pixel-perfectionist merged 2 commits intoJul 29, 2024
Merged
Conversation
Collaborator
📊 Bundle size report
🤖 This report was generated against ceacd96379e6d7268d1807a318a9b6f7c48f519b |
pixel-perfectionist
force-pushed
the
feat/accordion-collpse-animation
branch
from
July 23, 2024 22:23
afd34e3 to
cb1f612
Compare
fabricteam
reviewed
Jul 23, 2024
pixel-perfectionist
force-pushed
the
feat/accordion-collpse-animation
branch
from
July 24, 2024 12:31
cb1f612 to
8e0a4d6
Compare
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 646 | 620 | 5000 | |
| Button | mount | 304 | 313 | 5000 | |
| Field | mount | 1154 | 1147 | 5000 | |
| FluentProvider | mount | 710 | 718 | 5000 | |
| FluentProviderWithTheme | mount | 86 | 79 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 33 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 76 | 69 | 10 | |
| MakeStyles | mount | 862 | 863 | 50000 | |
| Persona | mount | 1805 | 1723 | 5000 | |
| SpinButton | mount | 1434 | 1436 | 5000 | |
| SwatchPicker | mount | 1663 | 1647 | 5000 |
pixel-perfectionist
force-pushed
the
feat/accordion-collpse-animation
branch
3 times, most recently
from
July 26, 2024 17:03
9ac27a7 to
cb9a64f
Compare
pixel-perfectionist
marked this pull request as ready for review
July 29, 2024 13:57
- Updated dependencies in `package.json` - Enhanced `useAccordionHeader.tsx` for collapse motion - Added `AccordionMotion.ts` - Updated types and rendering logic in Accordion components - Styled `useAccordionPanelStyles.styles.ts` for animations - Created stories custom motion Accordion
pixel-perfectionist
force-pushed
the
feat/accordion-collpse-animation
branch
from
July 29, 2024 14:38
61cd189 to
aac3254
Compare
layershifter
approved these changes
Jul 29, 2024
spmonahan
approved these changes
Jul 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
package.jsonuseAccordionHeader.tsxfor collapse motionAccordionMotion.tsuseAccordionPanelStyles.styles.tsfor animationsPrevious Behavior
AccordionPaneldidn't have a collapse animationNew Behavior
AccordionPanelgetscollapseMotionslotMotion slots allow to customize or replace built-in motion, see examples in #31984.
Related issues