feat: add presenceMotionSlot()#31984
Merged
layershifter merged 4 commits intoJul 17, 2024
Merged
Conversation
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | mount | 81 | 85 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 602 | 634 | 5000 | |
| Button | mount | 301 | 299 | 5000 | |
| Field | mount | 1130 | 1117 | 5000 | |
| FluentProvider | mount | 712 | 719 | 5000 | |
| FluentProviderWithTheme | mount | 81 | 85 | 10 | Possible regression |
| FluentProviderWithTheme | virtual-rerender | 39 | 34 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 89 | 83 | 10 | |
| MakeStyles | mount | 876 | 875 | 50000 | |
| Persona | mount | 1718 | 1708 | 5000 | |
| SpinButton | mount | 1365 | 1396 | 5000 | |
| SwatchPicker | mount | 1629 | 1681 | 5000 |
layershifter
force-pushed
the
feat/add-motion-slot-api
branch
from
July 12, 2024 11:41
7726b5d to
7624faa
Compare
Collaborator
📊 Bundle size report✅ No changes found |
layershifter
force-pushed
the
feat/add-motion-slot-api
branch
from
July 12, 2024 11:49
7624faa to
4caf0ea
Compare
layershifter
marked this pull request as ready for review
July 12, 2024 11:49
fabricteam
reviewed
Jul 12, 2024
bsunderhus
approved these changes
Jul 12, 2024
bsunderhus
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Minor nit picking but aside from that seems solid 💪🏻
layershifter
force-pushed
the
feat/add-motion-slot-api
branch
from
July 16, 2024 15:21
4caf0ea to
1891ee9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New Behavior
This PR adds
motionSlot()API that will be used in components have are usingcreatePresenceComponent()motions. For an implementation example, check #31132.Once integration, it will add customization of motions:
Related Issue(s)
Dialogcomponent feat: add motion slots to Dialog #31132.