feat(motion): add collapse motion for Tree#32163
Merged
pixel-perfectionist merged 1 commit intoAug 1, 2024
Merged
Conversation
Collaborator
📊 Bundle size report
Unchanged fixtures
|
pixel-perfectionist
marked this pull request as ready for review
July 30, 2024 18:12
pixel-perfectionist
force-pushed
the
feat/tree-collpse-animation
branch
from
July 30, 2024 23:37
f53b605 to
f687c5c
Compare
layershifter
approved these changes
Jul 31, 2024
Collaborator
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 79 | 10 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 646 | 633 | 5000 | |
| Button | mount | 300 | 306 | 5000 | |
| Field | mount | 1177 | 1156 | 5000 | |
| FluentProvider | mount | 710 | 709 | 5000 | |
| FluentProviderWithTheme | mount | 79 | 88 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 36 | 36 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 75 | 79 | 10 | Possible regression |
| MakeStyles | mount | 859 | 859 | 50000 | |
| Persona | mount | 1787 | 1778 | 5000 | |
| SpinButton | mount | 1421 | 1387 | 5000 | |
| SwatchPicker | mount | 1652 | 1692 | 5000 |
pixel-perfectionist
requested review from
a team and
micahgodbolt
as code owners
July 31, 2024 15:06
pixel-perfectionist
force-pushed
the
feat/tree-collpse-animation
branch
3 times, most recently
from
July 31, 2024 15:20
f2cc19d to
5c1a24a
Compare
pixel-perfectionist
force-pushed
the
feat/tree-collpse-animation
branch
2 times, most recently
from
July 31, 2024 15:25
28f8dc7 to
1b86ebb
Compare
bsunderhus
approved these changes
Jul 31, 2024
bsunderhus
left a comment
bsunderhus
left a comment
Contributor
There was a problem hiding this comment.
LGTM: we'd need to update #31548 to follow up on this new motions
fabricteam
reviewed
Jul 31, 2024
Contributor
|
This PR might be affected by #32173 |
robertpenner
approved these changes
Jul 31, 2024
robertpenner
left a comment
robertpenner
left a comment
Collaborator
There was a problem hiding this comment.
Let's link to the relevant motion design specs: the Collapse spec in Loop, and the Tree motion spec when it's ready (probably this week). Otherwise, looking good.
pixel-perfectionist
force-pushed
the
feat/tree-collpse-animation
branch
from
August 1, 2024 13:43
1b86ebb to
6bb51af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
renderTreedidn't have a collapse animationNew Behavior
renderTreegets the new slot for collapse motion:collapseMotionMotion slots allow to customize or replace built-in motion, see examples in #31984.
Design Specs
Fluent Motion Component Defaults
Related issues