fix(public-docsite-v9): render args table only for component stories#32467
Closed
dmytrokirpa wants to merge 1 commit into
Closed
fix(public-docsite-v9): render args table only for component stories#32467dmytrokirpa wants to merge 1 commit into
dmytrokirpa wants to merge 1 commit into
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Contributor
Author
|
Closing as it duplicates #32465 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
The Motion documentation is broken because the
componentis not specified in the Storybook's meta, and theArgsTableis attempting to render the component's props table.This is not a correct story definition from the Storybook's standpoint, as it doesn't satisfies SB's types.
New Behavior
As a temporary workaround, we could bypass
ArgsTablerendering for stories without component specified. However, ideally, we should not create stories without components. Stories are meant for components, and if we need to document something else, we should create anmdxfile with the documentation.Related Issue(s)