Skip to content

fix(docsite-v9): make motion docs work#32465

Merged
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:storybook/bug-fix/arg-table-props
Sep 5, 2024
Merged

fix(docsite-v9): make motion docs work#32465
Hotell merged 2 commits into
microsoft:masterfrom
Hotell:storybook/bug-fix/arg-table-props

Conversation

@Hotell

@Hotell Hotell commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

Previous Behavior

motion stories provided invalid Meta configuration resulting in throwing error when rendering stories

New Behavior

Motion stories render

  • motion stories provide valid Meta
  • docsite-v9 adds extra primaryStory assertion in order to provide better DX what went wrong
    • image

Related Issue(s)

@Hotell Hotell changed the title Storybook/bug fix/arg table props fix(docsite-v9): make motion docs work Sep 5, 2024
@fabricteam

Copy link
Copy Markdown
Collaborator

📊 Bundle size report

✅ No changes found

@Hotell
Hotell marked this pull request as ready for review September 5, 2024 10:21
@Hotell
Hotell requested review from a team as code owners September 5, 2024 10:21
@Hotell
Hotell enabled auto-merge (squash) September 5, 2024 10:21
@dmytrokirpa

dmytrokirpa commented Sep 5, 2024

Copy link
Copy Markdown
Contributor

@Hotell there are few more occurrences of component: null in stories.

diff --git a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
index 8dfd1360a9..5b3d9c25e3 100644
--- a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
+++ b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './Default.stories';
 
 export default {
   title: 'Components/Portal/toMountNodeProps',
-  component: null,
   parameters: {
     docs: {
       description: {
diff --git a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
index 6ee9101fb6..ffcf130699 100644
--- a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
+++ b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './UseAnnounceDefault.stories';

@Hotell

Hotell commented Sep 5, 2024

Copy link
Copy Markdown
Contributor Author

@Hotell there are few more occurrences of component: null in stories.

diff --git a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
index 8dfd1360a9..5b3d9c25e3 100644
--- a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
+++ b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './Default.stories';
 
 export default {
   title: 'Components/Portal/toMountNodeProps',
-  component: null,
   parameters: {
     docs: {
       description: {
diff --git a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
index 6ee9101fb6..ffcf130699 100644
--- a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
+++ b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './UseAnnounceDefault.stories';

nice finding ! ty

discussed offline - we gonna create a separate PR that will address those + migrating these misused .ts files to use .mdx only

@Hotell
Hotell merged commit 1786bfa into microsoft:master Sep 5, 2024
@Hotell
Hotell deleted the storybook/bug-fix/arg-table-props branch September 5, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: motion docs are broken

4 participants