fix(docsite-v9): make motion docs work#32465
Merged
Hotell merged 2 commits intoSep 5, 2024
Merged
Conversation
Collaborator
📊 Bundle size report✅ No changes found |
Hotell
marked this pull request as ready for review
September 5, 2024 10:21
Hotell
enabled auto-merge (squash)
September 5, 2024 10:21
dmytrokirpa
approved these changes
Sep 5, 2024
Contributor
|
@Hotell there are few more occurrences of diff --git a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
index 8dfd1360a9..5b3d9c25e3 100644
--- a/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
+++ b/packages/react-components/react-portal/stories/src/toMountNodeProps/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './Default.stories';
export default {
title: 'Components/Portal/toMountNodeProps',
- component: null,
parameters: {
docs: {
description: {
diff --git a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
index 6ee9101fb6..ffcf130699 100644
--- a/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
+++ b/packages/react-components/react-shared-contexts/stories/src/UseAnnouce/index.stories.tsx
@@ -4,7 +4,6 @@ export { Default } from './UseAnnounceDefault.stories'; |
Contributor
Author
nice finding ! ty discussed offline - we gonna create a separate PR that will address those + migrating these misused |
layershifter
approved these changes
Sep 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
motion stories provided invalid
Metaconfiguration resulting in throwing error when rendering storiesNew Behavior
Motion stories render
MetaprimaryStoryassertion in order to provide better DX what went wrongRelated Issue(s)