fix(public-docsite-v9): fix toMountNodeProps and UseAnnounce broken pages#32469
Merged
dmytrokirpa merged 3 commits intoSep 5, 2024
Merged
Conversation
dmytrokirpa
added
Type: Bug 🐛
Area: Documentation
Component: Portal
Storybook
and removed
Component: Portal
labels
Collaborator
📊 Bundle size report✅ No changes found |
dmytrokirpa
marked this pull request as ready for review
September 5, 2024 13:06
Hotell
approved these changes
Sep 5, 2024
layershifter
approved these changes
Sep 5, 2024
Co-authored-by: Martin Hochel <hochelmartin@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous Behavior
https://react.fluentui.dev/?path=/docs/utilities-aria-live-useannounce--docs and https://react.fluentui.dev/?path=/docs/components-portal-tomountnodeprops--docs were broken because of not valid story meta definition,
component: nullis not supported by Storybook.New Behavior
Eliminate the
component: nulland include theas Metatype to ensure the Storybook's meta is valid.Related Issue(s)