Updating filetypeicon assets at 64x64 size (CDN URL update) - #33966
Merged
spmonahan merged 10 commits intoMar 13, 2025
Conversation
📊 Bundle size report
Unchanged fixtures
|
|
Pull request demo site: URL |
bigbadcapers
commented
Mar 10, 2025
fabricteam
reviewed
Mar 12, 2025
dzearing
approved these changes
Mar 13, 2025
khmakoto
approved these changes
Mar 13, 2025
Member
|
can confirm, new CDN url is valid |
micahgodbolt
approved these changes
Mar 13, 2025
Contributor
Author
|
thanks for the review and approvals yall. @khmakoto or @dzearing do either of you have Merge authorization? also, do you know how i could 'certify myself' to get merge auth when the code updates these items above? it's part of a regular filetypeicon update process i'd hate to keep bugging people with |
Member
|
@bigbadcapers I'll merge it once CI passes 😄 @JustSlone could we give merge permissions to @bigbadcapers? |
Member
|
/azp run Visual Regression Tool - PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
thank you! amazing. btw, the Visual Regression tool, i've checked every time, it seems to regularly give false positives related to the charting component with these filetypeicon PRs, not sure if that's something common but just sharing for background. im totally okay categorizing them as they come. |
Collaborator
@bigbadcapers the system says you should already have write access to the repo which will allow merging PRs via membership in this team: https://github.com/orgs/microsoft/teams/fluentui-write/members Not sure what is preventing the merging? |
mainframev
pushed a commit
to mainframev/fluentui
that referenced
this pull request
Jun 9, 2025
3 tasks
tudorpopams
pushed a commit
to tudorpopams/fluentui
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Verified:
masterbranchyarn changeand build update to refresh the API .md file.Previous Behavior
Icons requested for filetypes at 64x64 base size were showing older versions.
New Behavior
Icon assets in the backing CDN have now been refreshed (PNG and SVG at various screen densities.