Adding alias to support oneCDN URL updates (for when icons update) - #35488
Merged
JustSlone merged 2 commits intoNov 13, 2025
Conversation
bigbadcapers
requested review from
a team,
JustSlone,
jurokapsiar and
tudorpopams
as code owners
November 13, 2025 20:22
📊 Bundle size report✅ No changes found |
|
Pull request demo site: URL |
JustSlone
reviewed
Nov 13, 2025
JustSlone
approved these changes
Nov 13, 2025
tudorpopams
pushed a commit
to tudorpopams/fluentui
that referenced
this pull request
Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please verify that:
masterbranchyarn changelocally (looks like it's not required for edits under .github based on previous PRs, but lmk if i got that wrong)The OneCDN that hosts app and filetype icons used throughout FluentUI elements is versioned and the style-utilities package should get updated when we improve our filetype icon coverage or fix app icons. ( Example PR: #33966 )
These updates used to only require changes in the react-file-type-icons package but with that security change, the PRs require one more step after review/approval that I'm hoping to spare annoyance on other folks every time they're done and tested in branch and just need merge.