Adding RTL support for DetailsList drag-drop to reorder columns#7267
Conversation
|
Hey @arkogupta I just tested out your changes locally and I'm not seeing the right behavior for the DetailsList Drag & Drop example in RTL.
It looks like the columns are still either jumping to the far left or the far right. |
|
Hmmm... unsure why @natalieethell ran into the above 🤔. In my local testing this seems to work well. Here is a test pass in Edge:
Both the column positions and drop anchor markers seem correct. Will sync with @natalieethell offline to see what the culprit is. |
KevinTCoughlin
left a comment
KevinTCoughlin
left a comment
There was a problem hiding this comment.
Change LGTM in my testing (both LTR/RTL) 
Will sync with @natalieethell to confirm it also works for her, please wait for that to merge.
|
Update: got it working! Just synced up with @KevinTCoughlin offline and it works for me when I click the "Render in RTL" option on the gear icon in the top right corner of the demo page. Looks good. (Before, I was just changing the I'll approve this, but could we resolve the comment above before merging? Thanks! |
|
🎉 Handy Links: |
* master: (55 commits) Applying package updates. default spellCheck=false in BasePicker (microsoft#7301) Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211) Dropdown component honors ariaLabel prop (microsoft#7292) Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299) Fix microsoft#7258 - Documentation is missing for button (microsoft#7302) Applying package updates. Add customizer scope to TeachingBubbleContent (microsoft#7294) Applying package updates. DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119) Add card dgl functionality (microsoft#7287) Only support LTS versions of Node 8 and 10 (microsoft#7290) add shift into delete action (microsoft#7274) Update CODEOWNERS Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267) Applying package updates. Improve TeachingBubble usage docs (microsoft#7266) Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261) Re-adding animation for drag-n-drop to reorder columns (microsoft#7213) Update DetailsList Drag & Drop Example Snapshot (microsoft#7272) ...
4 participants
Pull request checklist
$ npm run changeDescription of changes
This change adds support for dragging and dropping columns to reorder them, in RTL languages.
Microsoft Reviewers: Open in CodeFlow