Skip to content

default spellCheck=false in BasePicker#7301

Merged
joschect merged 4 commits into
microsoft:masterfrom
yumikohey:huaxi/no-spellcheck-in-picker
Dec 6, 2018
Merged

default spellCheck=false in BasePicker#7301
joschect merged 4 commits into
microsoft:masterfrom
yumikohey:huaxi/no-spellcheck-in-picker

Conversation

@yumikohey

@yumikohey yumikohey commented Dec 4, 2018

Copy link
Copy Markdown
Contributor

Pull request checklist

Description of changes

No autocorrect pops up when typing in Safari browser.

Focus areas to test

(optional)

Microsoft Reviewers: Open in CodeFlow

@Vitalius1

Copy link
Copy Markdown
Contributor

Needs a snapshot update.

@yumikohey

Copy link
Copy Markdown
Contributor Author

@Vitalius1 Thanks. Updated snapshot.

@joschect
joschect merged commit 2692f4a into microsoft:master Dec 6, 2018
@msft-github-bot

Copy link
Copy Markdown
Contributor

🎉office-ui-fabric-react@v6.111.0 has been released which incorporates this pull request.:tada:

Handy Links:

Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Dec 7, 2018
* master: (55 commits)
  Applying package updates.
  default spellCheck=false in BasePicker (microsoft#7301)
  Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211)
  Dropdown component honors ariaLabel prop (microsoft#7292)
  Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299)
  Fix microsoft#7258 - Documentation is missing for button (microsoft#7302)
  Applying package updates.
  Add customizer scope to TeachingBubbleContent (microsoft#7294)
  Applying package updates.
  DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119)
  Add card dgl functionality (microsoft#7287)
  Only support LTS versions of Node 8 and 10 (microsoft#7290)
  add shift into delete action (microsoft#7274)
  Update CODEOWNERS
  Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267)
  Applying package updates.
  Improve TeachingBubble usage docs (microsoft#7266)
  Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261)
  Re-adding animation for drag-n-drop to reorder columns (microsoft#7213)
  Update DetailsList Drag & Drop Example Snapshot (microsoft#7272)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ExtendedPeoplePicker should pass in autocorrect=off and spellcheck=false to Autofill as native props

5 participants