Publish package to more distros and refactoring - #4455
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4455 +/- ##
=======================================
Coverage ? 86.00%
=======================================
Files ? 56
Lines ? 15521
Branches ? 0
=======================================
Hits ? 13349
Misses ? 2172
Partials ? 0 ☔ View full report in Codecov by Sentry. |
Nick Banks (nibanks)
approved these changes
Aug 14, 2024
Daiki AMINAKA (ami-GS)
enabled auto-merge (squash)
August 14, 2024 20:54
Daiki AMINAKA (ami-GS)
added a commit
that referenced
this pull request
Aug 15, 2024
* Publish package to more distros and refactoring * fix? * fix * fix * fix file dependencies * fix * fix * fix * fix
Daiki AMINAKA (ami-GS)
added a commit
that referenced
this pull request
Aug 15, 2024
* Delete Prepare Machine and Checkout from Linux Package Testing (#4456) * Prepare Machine and msquic checkout should not be necessary for testing linux packages * Install dependencies with package * Try to fix dependencies * Fix validated set * Publish package to more distros and refactoring (#4455) * Publish package to more distros and refactoring * fix? * fix * fix * fix file dependencies * fix * fix * fix * fix * Make rpm package for x86_64 (#4459) * Make rpm package for x86_64 * Accidentally deleted debug flag * fix syntax * add azure linux3 arm * increment patch 2.4.4 --------- Co-authored-by: Ahmet Ibrahim Aksoy <aaksoy@microsoft.com>
| $Libraries += Join-Path $ArtifactsDir "msquic.lib" | ||
| } | ||
|
|
||
| # if datapath_raw_xdp_kern.o exists under $ArtifactsDir, $UseXdp to be true |
There was a problem hiding this comment.
Yes, this is correct but we shouldn't tie $Time64Distro to this, because for example: Ubuntu 24.04 is still Time64Distro but if we're compiling it against ARM, dependency will get converted to libssl3 from libssl3t64
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Testing
Use internal pipeline
Documentation
N/A