Make rpm package for x86_64 - #4459
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4459 +/- ##
==========================================
+ Coverage 84.87% 85.67% +0.79%
==========================================
Files 56 56
Lines 15521 15521
==========================================
+ Hits 13174 13298 +124
+ Misses 2347 2223 -124 ☔ View full report in Codecov by Sentry. |
| --depends "libcrypto.so.${TLSVERSION}()(${BITS})" \ | ||
| --depends "libnuma.so.1()(${BITS})" \ | ||
| --depends "libxdp >= 1.4.0" \ | ||
| --depends "libnl3 >= 3.0" \ |
There was a problem hiding this comment.
do we need libnl or is that dependency libxdp will drag in? I would put here as little as really needed.
There was a problem hiding this comment.
libnl is needed when using xdp (raw socket). to resolve route to next hop.
There was a problem hiding this comment.
Yeah, MsQuic itself resolves the route when using XDP. It's not an XDP dependency.
Nick Banks (nibanks)
left a comment
Nick Banks (nibanks)
left a comment
There was a problem hiding this comment.
If it works, ship it!
| --log error \ | ||
| ${FILES} | ||
| fi | ||
| if [ "$XDP" == "True" ] && [[ "$ARCH" == x* ]]; then |
There was a problem hiding this comment.
do we need the arch check? XDP is off by default so I would think we should package it when we are told to. e.g. the distro/arch choices should not be here IMHO.
There was a problem hiding this comment.
It is okey (for me) to deliver, but we have never tried build and run for arm.
Nick Banks (@nibanks) ?
There was a problem hiding this comment.
arm build doesn't enable xdp at build time. so this if else is needed
|
I just realized that Publish pipeline for kernel 6.8 for rpm package only publish arm packages kernel 6.8 kernel 5.15 |
oops, this PR itself aims to resolve this problem (after merging)🤦♂️ |
* Make rpm package for x86_64 * Accidentally deleted debug flag * fix syntax * add azure linux3 arm
* Delete Prepare Machine and Checkout from Linux Package Testing (#4456) * Prepare Machine and msquic checkout should not be necessary for testing linux packages * Install dependencies with package * Try to fix dependencies * Fix validated set * Publish package to more distros and refactoring (#4455) * Publish package to more distros and refactoring * fix? * fix * fix * fix file dependencies * fix * fix * fix * fix * Make rpm package for x86_64 (#4459) * Make rpm package for x86_64 * Accidentally deleted debug flag * fix syntax * add azure linux3 arm * increment patch 2.4.4 --------- Co-authored-by: Ahmet Ibrahim Aksoy <aaksoy@microsoft.com>
4 participants
Description
rpm package generation is skipped when
(!xdp && x86_64). remove the check.#4450
Testing
running internal CI
Documentation
N/A