Make sure we send options for the install_typings in both cases.#1576
Merged
paulvanbrenk merged 5 commits intomicrosoft:v1.3.xfrom May 12, 2017
Merged
Make sure we send options for the install_typings in both cases.#1576paulvanbrenk merged 5 commits intomicrosoft:v1.3.xfrom
paulvanbrenk merged 5 commits intomicrosoft:v1.3.xfrom
Conversation
billti
requested changes
May 12, 2017
| typingsTool.installTypingsForProject(options) | ||
| } else { | ||
| typingsTool.runAll(packagesToInstall.map(function (name) { | ||
| var options = { |
Member
There was a problem hiding this comment.
This won't work as intended. By having options outside of this function body, you are passing the same options object in with every call to installTypingsForPackage, so unless it executes synchronously and doesn't refer to the object again - all later uses refer to the same object - so only the last settings take effect. Safer to just create a different 'options' object (maybe inline) if the other branch of the 'if' statement.
That should be a `,`
and a property in an object literal
online editor is the worst
billti
approved these changes
May 12, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a null reference on options in the case of
installTypingsForProject