Skip to content

Make sure we send options for the install_typings in both cases. #1576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulvanbrenk merged 5 commits into from
May 12, 2017
Merged

Make sure we send options for the install_typings in both cases. #1576

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
06c4e44
Make sure we send options for the install_typings in both cases.
May 12, 2017
b37d364
don't re-use the same object
May 12, 2017
7f9ebcd
Update install_typings
paulvanbrenk May 12, 2017
f00d0a0
Update install_typings
paulvanbrenk May 12, 2017
5dce673
Update install_typings
paulvanbrenk May 12, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Nodejs/Product/Nodejs/TypingsAcquisitionTool/bin/install_typings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,14 @@ var argv = minimist(process.argv.slice(2), {
});

var emitter = new events.EventEmitter();

var packagesToInstall = argv._;

if (!packagesToInstall.length) {
// top level package install
typingsTool.installTypingsForProject(options)
typingsTool.installTypingsForProject({ save: argv.save,
emitter: emitter,
global: true,
cwd: argv.cwd || process.cwd()})
} else {
typingsTool.runAll(packagesToInstall.map(function (name) {
var options = {
Expand All @@ -31,6 +33,7 @@ if (!packagesToInstall.length) {
global: name === "node", // Assume everything else refers to a CommonJS module
cwd: argv.cwd || process.cwd()
};

return typingsTool.installTypingsForPackage(name, options);
}));
}