Conversation
I added the text attribute after bulk converting all *.cs files to crlf line endings, thinking that it would force edits to also use crlf going foward. Instead, it's causing a ton of trouble for me and introducing lots of fake edits. Here's the problem: * On a clean branch, use VS to edit a file. * Verify that the file has crlf line endings before editing it. * Save the file. * File still has crlf line endings. * git now shows the entire file has been changed. Removing the text attribute gets us back to where we started and fixed the problem for me.
|
Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
| using System.Text.RegularExpressions; | ||
| using EnvDTE; | ||
| using Microsoft.VisualStudio.TemplateWizard; | ||
There was a problem hiding this comment.
I've tried but I can't undo this change. It's whitespace only but git refuses to see that anything has been changed even after checking out this file directly from this repo directly.
|
Closing in favor of #730. BTW from what I can tell, the issue was that git got stuck in this very odd state - with the eol=crlf flag set, the files should be represented as LF in the repo. But there was a set of files that were both CRLF locally and in the repo. So once you touched some files, locally it didn't really look any different, but the diff was reporting back that the entire file had changed because it was about to do an invisible-to-the-user conversion from CRLF to LF. I suspect your other PR #709 didn't catch this because |
I added the text attribute after bulk converting all *.cs files to crlf line endings, thinking that it would force edits to also use crlf going foward. Instead, it's causing a ton of trouble for me and introducing lots of fake edits.
Here's the problem:
Removing the text attribute gets us back to where we started and fixed the problem for me.