Closed
Conversation
**Defect** To get string resources, we currently, access everything through an SR class. This class hardcodes a bunch of strings to lookup resources in a resx by name. Hardcoding these strings is not great because these strings can get out of sync with the actual resx file. **Fix** This hooks up the resx file to generate an typed cs file automatically. This ensures that the resx file and the string resource uses cannot get out of sync.
|
Hi @mjbvz, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
Let's table this change for now. I understand it's a simple refactor, but it's is a rather large change to take and verify so close to a release, and isn't really solving any immediate problems. |
This was referenced Oct 17, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defect
To get string resources, we currently, access everything through an SR class. This class hardcodes a bunch of strings keys to lookup resources in a resx. Hardcoding these strings is not great because these strings can get out of sync with the actual rest file .
Fix
This hooks up the resx file to generate an typed cs file automatically. This ensures that the resx file and the string resource uses cannot get out of sync.
The existing class is also kept around since a number of places are using the resources ids as attribute arguments currently.
Sorry about the
Common/Tests/Utilities.UI/UI/InteractiveWindow.csgetting included in this change. It's just a line ending change that should be resolved once #727 goes in.