Skip to content

On-Device Training - Enable loading from buffer - #16417

Merged
askhade merged 22 commits into
mainfrom
askhade/ODT_enable_loading_from_buffer
Aug 23, 2023
Merged

On-Device Training - Enable loading from buffer#16417
askhade merged 22 commits into
mainfrom
askhade/ODT_enable_loading_from_buffer

Conversation

@askhade

@askhade askhade commented Jun 19, 2023

Copy link
Copy Markdown
Contributor

Description

This PR contains C and C++ API updates for On Device Training to enable loading all the models from buffer.
Enabling loading from buffer for checkpoint will be done in a separate PR.

Motivation and Context

This is required for web bindings

@askhade
askhade requested review from baijumeswani and pengwa June 20, 2023 04:16
@baijumeswani baijumeswani added the training issues related to ONNX Runtime training; typically submitted using template label Jun 20, 2023
Comment thread orttraining/orttraining/training_api/utils.h Outdated
Comment thread orttraining/orttraining/training_api/utils.h Outdated
Comment thread orttraining/orttraining/training_api/include/onnxruntime_training_cxx_api.h Outdated
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Outdated
Comment thread orttraining/orttraining/training_api/optimizer.cc Outdated
Comment thread csharp/src/Microsoft.ML.OnnxRuntime/Training/NativeTrainingMethods.shared.cs Outdated
Comment thread orttraining/orttraining/training_api/utils.h Outdated
Comment thread orttraining/orttraining/training_api/module.h Outdated
Comment thread orttraining/orttraining/training_api/utils.h Outdated
Comment thread orttraining/orttraining/training_api/optimizer.cc Outdated
Comment thread orttraining/orttraining/training_api/module.h
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Outdated
Comment thread orttraining/orttraining/training_api/module.cc Outdated
Comment thread orttraining/orttraining/test/training_api/core/training_capi_tests.cc Outdated
Comment thread orttraining/orttraining/training_api/module.cc Outdated
Comment thread orttraining/orttraining/training_api/optimizer.cc
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Fixed
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Fixed
Comment thread orttraining/orttraining/training_api/optimizer.cc Outdated
Comment thread orttraining/orttraining/training_api/utils.h Outdated
pengwa
pengwa previously approved these changes Aug 8, 2023

@pengwa pengwa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides few minor comments submitted earlier.

pengwa
pengwa previously approved these changes Aug 9, 2023
baijumeswani
baijumeswani previously approved these changes Aug 9, 2023
Comment thread orttraining/orttraining/training_api/utils.h
@askhade
askhade dismissed stale reviews from baijumeswani and pengwa via 7197595 August 16, 2023 20:46
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Fixed
Comment thread orttraining/orttraining/training_api/onnxruntime_training_c_api.cc Fixed
baijumeswani
baijumeswani previously approved these changes Aug 18, 2023
@askhade
askhade merged commit 56102ec into main Aug 23, 2023
@askhade
askhade deleted the askhade/ODT_enable_loading_from_buffer branch August 23, 2023 02:59
@faxu faxu added the triage:approved Approved for cherrypicks for release label Aug 24, 2023
snnn pushed a commit that referenced this pull request Aug 28, 2023
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

training issues related to ONNX Runtime training; typically submitted using template triage:approved Approved for cherrypicks for release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants