Skip to content

[js/web] JSEP Gemm for opset 13 - #16936

Merged
guschmue merged 8 commits into
microsoft:mainfrom
dakenf:jsep-gemm-opset13
Aug 23, 2023
Merged

[js/web] JSEP Gemm for opset 13#16936
guschmue merged 8 commits into
microsoft:mainfrom
dakenf:jsep-gemm-opset13

Conversation

@dakenf

@dakenf dakenf commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

Description

Added JSEP Gemm registration for opset 13. It was falling back to CPU provider as CPU has it for 13

@guschmue guschmue added the ep:WebGPU ort-web webgpu provider label Jul 31, 2023
@guschmue

guschmue commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jul 31, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 16936 in repo microsoft/onnxruntime

@guschmue

guschmue commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jul 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

guschmue
guschmue previously approved these changes Jul 31, 2023
View reviewed changes
@guschmue

guschmue commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

can you run npm run build:doc to make the ci pipeline happy ?

@guschmue

guschmue commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jul 31, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 16936 in repo microsoft/onnxruntime

@guschmue

guschmue commented Jul 31, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Jul 31, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 16936 in repo microsoft/onnxruntime

@guschmue

guschmue commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2023

Copy link
Copy Markdown

No commit pushedDate could be found for PR 16936 in repo microsoft/onnxruntime

@guschmue

guschmue commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 6 pipeline(s).

@guschmue

guschmue commented Aug 1, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 1, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 9 pipeline(s).

@guschmue

guschmue commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

CI pipeline is nagging about doc update. npm run build:doc should fix it.

@dakenf

dakenf commented Aug 2, 2023

Copy link
Copy Markdown
Contributor Author

CI pipeline is nagging about doc update. npm run build:doc should fix it.

Done. However it did some unrelated changes but that could be because of some previous merge conflicts.
Do you have a doc with a checklist before contributing so I won't forget to do stuff like that?

@guschmue

guschmue commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 2, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 2, 2023

Copy link
Copy Markdown
Contributor

we can come up with a checklist and we are also changing the CI to run these kinds of checks much earlier.

@guschmue

guschmue commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 4, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 4, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 4, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 12, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 12, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 17, 2023

Copy link
Copy Markdown
Contributor

/azp run Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline,Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,Windows ARM64 QNN CI Pipeline,Windows CPU CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 17, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

/azp run ONNX Runtime Web CI Pipeline

@azure-pipelines

azure-pipelines Bot commented Aug 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@guschmue

guschmue commented Aug 22, 2023

Copy link
Copy Markdown
Contributor

/azp run Windows GPU CI Pipeline,Windows GPU TensorRT CI Pipeline,onnxruntime-binary-size-checks-ci-pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,orttraining-ortmodule-distributed

@azure-pipelines

azure-pipelines Bot commented Aug 22, 2023

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@guschmue
guschmue merged commit 5842144 into microsoft:main Aug 23, 2023
@faxu faxu added the triage:approved Approved for cherrypicks for release label Aug 24, 2023
Lafi7e pushed a commit that referenced this pull request Aug 28, 2023
@dakenf Guenther Schmuelling @Lafi7e
[js/web] JSEP Gemm for opset 13 (#16936)
3e6e73b 
### Description
Added JSEP Gemm registration for opset 13. It was falling back to CPU
provider as CPU has it for 13

---------

Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com>
snnn pushed a commit that referenced this pull request Aug 28, 2023
@Lafi7e
Cherry-pick 1st Round (#17308)
198fc90 
Cherry-pick 1st round for rel-1.16.0 from
https://github.com/microsoft/onnxruntime/issues?q=label%3Arelease%3A1.16+label%3Atriage%3Aapproved+is%3Aclosed
except #17201 because it caused UT failure and is not fixed yet.

PR list:
#16417
#16936
#17000
#17236
#17238
#17240
#17252
#17255
#17258
#17265
#17267
#17277
kleiti pushed a commit to kleiti/onnxruntime that referenced this pull request Mar 22, 2024
@dakenf Guenther Schmuelling @kleiti
[js/web] JSEP Gemm for opset 13 (microsoft#16936)
11aa4d5 
### Description
Added JSEP Gemm registration for opset 13. It was falling back to CPU
provider as CPU has it for 13

---------

Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com>
siweic0 pushed a commit to siweic0/onnxruntime-web that referenced this pull request May 9, 2024
@dakenf Guenther Schmuelling
[js/web] JSEP Gemm for opset 13 (microsoft#16936)
6a48d9a 
### Description
Added JSEP Gemm registration for opset 13. It was falling back to CPU
provider as CPU has it for 13

---------

Co-authored-by: Guenther Schmuelling <guschmue@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers
@satyajandhyala satyajandhyala satyajandhyala approved these changes
@guschmue guschmue guschmue left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ep:WebGPU ort-web webgpu provider triage:approved Approved for cherrypicks for release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dakenf @guschmue @satyajandhyala @faxu