Skip to content

[WIP] Fix BatchNormalization layer export issue in ONNX model - #2988

Draft
justinchuby with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-batchnormalization-onnx-issue
Draft

[WIP] Fix BatchNormalization layer export issue in ONNX model#2988
justinchuby with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-batchnormalization-onnx-issue

Conversation

Copilot AI commented Aug 4, 2026

Copy link
Copy Markdown
Contributor
  • Verify final name-fixing behavior and optimizer test conventions
  • Add a focused regression test for unnamed optional outputs
  • Remove the optimizer step that reassigns cleared output names
  • Run targeted tests, lintrunner, secret scan, and security validation

Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot AI requested review from justinchuby and a lite review from Copilot and removed request for Copilot August 4, 2026 19:12
@justinchuby

Copy link
Copy Markdown
Collaborator

@copilot name fix pass is still needed. Let me know if onnx-ir needs updating or if there is another way to fix it

Co-authored-by: justinchuby <11205048+justinchuby@users.noreply.github.com>
Copilot AI requested a lite review from Copilot and removed request for Copilot August 5, 2026 15:22
@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.64%. Comparing base (457a260) to head (0fc3b8b).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2988   +/-   ##
=======================================
  Coverage   72.63%   72.64%           
=======================================
  Files         265      265           
  Lines       32205    32212    +7     
  Branches     3041     3041           
=======================================
+ Hits        23392    23399    +7     
  Misses       7779     7779           
  Partials     1034     1034           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

BatchNormalization layer with training_mode=1 results in incorrect ONNX model

2 participants