Skip to content
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions onnxscript/optimizer/_optimizer.py
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ def optimize_ir(
common_passes.CommonSubexpressionEliminationPass(),
common_passes.OutputFixPass(),
common_passes.NameFixPass(),
common_passes.RemoveUnusedNodesPass(),
]
if inline:
# Inline all functions first before optimizing
Expand Down
26 changes: 26 additions & 0 deletions onnxscript/optimizer/_optimizer_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,32 @@ def test_static_split_to_sequence_with_uneven_split_ir(self):
self.assertEqual(len(model_ir.graph.node(0).outputs), 2)
self.assertEqual(model_ir.graph.node(0).op_type, "Split")

def test_name_fix_preserves_unnamed_unused_outputs(self):
model_proto = onnx.parser.parse_model(
"""
<ir_version: 10, opset_import: ["" : 18]>
main_graph (
float[1, 2, 3, 3] x,
float[2] scale,
float[2] bias,
float[2] mean,
float[2] variance
) => (float[1, 2, 3, 3] y) {
y, running_mean, running_var = BatchNormalization
<training_mode: int = 1> (x, scale, bias, mean, variance)
}
"""
)
model_ir = ir.serde.deserialize_model(model_proto)
model_ir.graph.inputs[1].name = "x"

optimizer.optimize_ir(model_ir, num_iterations=1, onnx_shape_inference=False)

self.assertEqual([input.name for input in model_ir.graph.inputs[:2]], ["x", "x_1"])
self.assertEqual(
[output.name for output in model_ir.graph.node(0).outputs], ["y", "", ""]
)


if __name__ == "__main__":
unittest.main()
Loading