chore(driver): roll to 1.62.0 - #1954
Open
dcrousso wants to merge 1 commit into
Open
Conversation
roll the driver to `1.62.0` and regenerate the Java interfaces from the `v1.62.0` docs upstream reverted the `routeFromHAR` `interceptAPIRequests` option in `1.62`, so drop the matching `setInterceptAPIRequests` builder along with `HARRouter.addAPIRequestRoute` and the test covering it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rolls the driver to
1.62.0and regenerates the Java interfaces from thev1.62.0documentation.Upstream removed the
routeFromHARinterceptAPIRequestsoption before1.62.0in microsoft/playwright#41964 and microsoft/playwright#41965. This drops the generatedinterceptAPIRequestsfield, thesetInterceptAPIRequestsbuilder, theHARRouter.addAPIRequestRoutehelper, therouteAPIRequestsFromHarandunrouteAPIRequestsFromHarcalls, and their test.shouldNotInterceptAPIRequestContextRequestsByDefaultremains because that behavior still holds.Firefox
153fixes microsoft/playwright#38919, so the worker locale test now uses the context locale expectation for every browser.Validation:
mvn compilesucceedsmvn test -f playwrightruns1696tests with26skipped testsTestBrowserContextHarpasses with27testsTestWorkerspasses on Firefox and ChromiumPW_SRC_DIRpinned tov1.62.0ate3950d9c140d007bd52853b45813c6274b24e36fTestChromiumTracing.shouldSupportABufferWithoutAPathreproducesPASS FAIL PASSon both this branch and the prior driver, while passing consistently in isolation.