Fixed code quality issues

[withshubh]

Description

Hi 👋
I ran the DeepSource analysis on the forked copy of this repo and found some interesting code quality issues.

Motivation and Context

Some of the issues I have fixed boost minor performance and a few removes the anti-patterns in code.

Types of changes

• Fix bugs
• Add new feature
• Update documentation

Summary of changes

• Removed length check in favour of truthiness of the object
• Removed unnecessary use of comprehension
• Removed methods with unnecessary super delegation
• Used literal syntax to create data structure
• Refactored unnecessary else / elif when if block has a continue statement
• Refactored the comparison involving not
• Added .deepsource.toml file

[Derek-Wds]

Hi @withshubh , can you double check your modification since it seems the unit test failed. You can run the unit test with pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.

[withshubh]

Hey @Derek-Wds 👋

The fixes in this PR were made using DeepSource Auto-fix feature.

Can you give DeepSource a try on this repo? ✨
The repo already contains the configuration file. All you need to do is Signup here and then activate analysis here.

Activating analysis will help you to continuously analyze the repo for code quality issues and you can fix most of the fix using auto-fix feature.

[withshubh]

Hi @you-n-g @Derek-Wds 👋

Did you try out DeepSource? I'd like to get your feedback ✨

[you-n-g]

Hi @withshubh
Thanks for your adivce.
I setup it just now. But I'm not sure if I did it correctly.

[withshubh]

Hi @you-n-g

Follow these steps:

• Install DeepSource on your repository here.
• Activate analysis here.
• you don't need to create the .deepsource.toml config file since the repo already has one through this PR.

And there you go 💖

[you-n-g]

@withshubh
Thanks so much!
DeepSource is really a powerful tool.
I can't manage the account of microsoft. But I install DeepSource on my personal account.

It has been installed here