Skip to content

Fixed code quality issues #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
you-n-g merged 11 commits into from
Mar 12, 2021
Merged

Fixed code quality issues #311

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
f277a66
Add .deepsource.toml
withshubh Mar 6, 2021
07eef18
Remove length check in favour of truthiness of the object
withshubh Mar 6, 2021
6f034cc
Remove unnecessary use of comprehension
withshubh Mar 6, 2021
5015d21
Remove methods with unnecessary super delegation.
withshubh Mar 6, 2021
a62d1a1
Use literal syntax to create data structure
withshubh Mar 6, 2021
dc86a6a
Refactor unnecessary `else` / `elif` when `if` block has a `continue`…
withshubh Mar 6, 2021
aab5c5b
Refactor the comparison involving `not`
withshubh Mar 6, 2021
4fbb5a0
revert fixes that failed unit test
withshubh Mar 12, 2021
5f8d0e0
Merge branch 'main' into main
withshubh Mar 12, 2021
0969c3e
formatted with black
withshubh Mar 12, 2021
e41373b
revert fix
withshubh Mar 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove length check in favour of truthiness of the object 
Signed-off-by: shubhendra <withshubh@gmail.com>
  • Loading branch information
@withshubh
withshubh committed Mar 6, 2021
commit 07eef183372e7dda39f7b427ff5cf22427a31bc8
2 changes: 1 addition & 1 deletion qlib/contrib/backtest/exchange.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ def __init__(
self.limit_threshold = limit_threshold
# TODO: the quote, trade_dates, codes are not necessray.
# It is just for performance consideration.
if trade_dates is not None and len(trade_dates):
if trade_dates is not None and trade_dates:
start_date, end_date = trade_dates[0], trade_dates[-1]
else:
self.logger.warning("trade_dates have not been assigned, all dates will be loaded")
Expand Down