Localize new MSTest.TestAdapter runsettings warnings to fix main pipeline#9868
Merged
Conversation
The native MTP integration (#9748) moved the 'Runsettings loggers/datacollectors are not supported' warnings from the VSTest bridge (ExtensionResources) into MSTest.TestAdapter (PlatformAdapterResources). The two new resource strings were added to the neutral resx but their xlf targets were still state=new with the English source text, so the satellites emitted English at runtime and the RunSettingsTests.UnsupportedRunSettingsEntriesAreFlagged_Localization acceptance test (which asserts on the localized fr-FR/it-IT text) failed on main. Copy the already-approved translations for these identical strings from the VSTest bridge ExtensionResources xlf files into PlatformAdapterResources across all locales and mark them state=translated. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 7a4950e0-232a-4f53-9d1a-60598c2a587d
Contributor
There was a problem hiding this comment.
Pull request overview
Localizes MSTest adapter runsettings warnings by copying existing VSTest bridge translations across all 13 supported locales.
Changes:
- Marks logger and data-collector warnings as translated.
- Aligns French and Italian output with acceptance-test expectations.
- Reuses existing sibling-resource translations.
Show a summary per file
| File | Description |
|---|---|
PlatformAdapterResources.cs.xlf |
Adds Czech translations. |
PlatformAdapterResources.de.xlf |
Adds German translations. |
PlatformAdapterResources.es.xlf |
Adds Spanish translations. |
PlatformAdapterResources.fr.xlf |
Adds French translations. |
PlatformAdapterResources.it.xlf |
Adds Italian translations. |
PlatformAdapterResources.ja.xlf |
Adds Japanese translations. |
PlatformAdapterResources.ko.xlf |
Adds Korean translations. |
PlatformAdapterResources.pl.xlf |
Adds Polish translations. |
PlatformAdapterResources.pt-BR.xlf |
Adds Brazilian Portuguese translations. |
PlatformAdapterResources.ru.xlf |
Adds Russian translations. |
PlatformAdapterResources.tr.xlf |
Adds Turkish translations. |
PlatformAdapterResources.zh-Hans.xlf |
Adds Simplified Chinese translations. |
PlatformAdapterResources.zh-Hant.xlf |
Adds Traditional Chinese translations. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 13
- Review effort level: Medium
Evangelink
enabled auto-merge (squash)
July 11, 2026 20:19
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🤖 This review was generated by Copilot from workflow run 29166716928.
Review Summary
LGTM — Straightforward localization fix that unblocks main.
Verification performed
| Check | Result |
|---|---|
| All 13 locale xlf files updated | ✅ cs, de, es, fr, it, ja, ko, pl, pt-BR, ru, tr, zh-Hans, zh-Hant |
source elements unchanged (English) |
✅ |
Locked terms (Runsettings, Microsoft.Testing.Platform) preserved in all targets |
✅ |
state changed from "new" → "translated" |
✅ |
fr-FR translation matches VSTestBridge ExtensionResources.fr.xlf source |
✅ ("Les datacollecteurs...", "Les loggers...") |
it-IT translation matches VSTestBridge ExtensionResources.it.xlf source |
✅ |
Translations match RunsettingsTests.UnsupportedRunSettingsEntriesAreFlagged_Localization assertions |
✅ |
No structural xlf changes (only target text + state attribute) |
✅ |
Dimensions assessed
Most of the 22 review dimensions (security, performance, concurrency, etc.) are not applicable to xlf-only changes. The relevant ones:
- Correctness: Translations are word-for-word copies of the already-approved VSTestBridge strings and match the test assertions.
- Internationalization: All 13 locales covered; locked terms preserved;
state="translated"correctly signals to XliffTasks that no retranslation is needed. - Maintainability: Minimal diff touching only the two new trans-units per file. When OneLocBuild eventually processes these strings it will either confirm or overwrite — no conflict risk.
No issues found.
0101
approved these changes
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
mainis red. The only failing test (e.g. build20260711.8) isRunSettingsTests.UnsupportedRunSettingsEntriesAreFlagged_Localization, failing on every locale case on both Linux and Windows. The test host emits English output where localized fr-FR / it-IT text is expected.Root cause
The native MTP integration refactor (#9748) moved the "Runsettings loggers/datacollectors are not supported by Microsoft.Testing.Platform and will be ignored" warnings out of the VSTest bridge (
ExtensionResources) intoMSTest.TestAdapter(PlatformAdapterResources).The two new strings were added to the neutral
PlatformAdapterResources.resx, but their.xlftargets were stillstate="new"carrying the English source text (OneLocBuild hadn't translated them yet). The satellite assemblies therefore contained English, and the acceptance test — which asserts on the real French/Italian translations — failed.Fix
These strings are word-for-word identical to already-approved translations in the sibling VSTest bridge
ExtensionResourcesxlf files. This PR copies those translations intoPlatformAdapterResources.<loc>.xlfacross all 13 locales and marks themstate="translated".UnsupportedRunsettingsLoggers+UnsupportedRunsettingsDatacollectors)targettext/state changed; sources and structure untouched (XliffTasks validation unaffected)…et seront ignorés) and it-IT (I logger/datacollector Runsettings non sono supportati…) now exactly match the test's regex/substring assertionsVerification
Confirmed the produced strings match the test assertions exactly and the xlf edits are minimal/structure-preserving. A full acceptance run requires a
-packbuild (~30+ min) and was not executed locally; the fix is deterministic given the assertions.