Restore MSTest.TestAdapter runsettings translations regressed by OneLocBuild #9912#9928
Merged
Merged
Conversation
…ocBuild #9912 OneLocBuild check-in #9912 reset every PlatformAdapterResources trans-unit from state=translated back to state=new (English source), breaking the localized runsettings warnings. This made UnsupportedRunSettingsEntriesAreFlagged_Localization fail because fr-FR/it-IT runs emitted English text. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 62a5b826-22ea-4fbb-a585-8fdb7f9ce345
Contributor
There was a problem hiding this comment.
Pull request overview
Restores approved MSTest.TestAdapter translations overwritten by OneLocBuild, fixing localized runsettings warnings.
Changes:
- Restores 11 translated resources across 13 locales.
- Preserves source text, identifiers, placeholders, and locked terms.
- Restores French and Italian acceptance-test expectations.
Show a summary per file
| File | Description |
|---|---|
| PlatformAdapterResources.cs.xlf | Restores Czech translations. |
| PlatformAdapterResources.de.xlf | Restores German translations. |
| PlatformAdapterResources.es.xlf | Restores Spanish translations. |
| PlatformAdapterResources.fr.xlf | Restores French translations. |
| PlatformAdapterResources.it.xlf | Restores Italian translations. |
| PlatformAdapterResources.ja.xlf | Restores Japanese translations. |
| PlatformAdapterResources.ko.xlf | Restores Korean translations. |
| PlatformAdapterResources.pl.xlf | Restores Polish translations. |
| PlatformAdapterResources.pt-BR.xlf | Restores Brazilian Portuguese translations. |
| PlatformAdapterResources.ru.xlf | Restores Russian translations. |
| PlatformAdapterResources.tr.xlf | Restores Turkish translations. |
| PlatformAdapterResources.zh-Hans.xlf | Restores Simplified Chinese translations. |
| PlatformAdapterResources.zh-Hant.xlf | Restores Traditional Chinese translations. |
Review details
- Files reviewed: 13/13 changed files
- Comments generated: 0
- Review effort level: Medium
Evangelink
added a commit
that referenced
this pull request
Jul 15, 2026
…ocBuild #9912 OneLocBuild check-in #9912 (fd05c11) reset the PlatformAdapterResources runsettings trans-units from state="translated" to state="new" with English target text, causing RunSettingsTests.UnsupportedRunSettingsEntriesAreFlagged_Localization (fr-FR/it-IT) to fail on Debug legs. Restores the approved translations from the main-branch fix #9928 (398e9d1). Only <target> values change; sources/IDs/.resx untouched, so XliffTasks stays green. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: c5a5f648-c002-4866-adb6-ddf4a284850b
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Main is red.
MSTest.Acceptance.IntegrationTests.RunSettingsTests.UnsupportedRunSettingsEntriesAreFlagged_Localizationfails for thefr-FRandit-ITcases: the localized runsettings warnings are emitted in English instead of the expected French/Italian text, so theAssertOutputMatchesRegex/AssertOutputContainsassertions fail.Root cause
The OneLocBuild auto check-in #9912 (
fd05c119c) regressedsrc/Adapter/MSTest.TestAdapter/Resources/xlf/PlatformAdapterResources.*.xlf: it reset everytrans-unitfromstate="translated"back tostate="new"with the English<source>text as the<target>. SinceMSTestRunSettings.csreads these strings viaPlatformAdapterResources.UnsupportedRunsettingsLoggers/UnsupportedRunsettingsDatacollectors, non-English runs emitted English text.This is a recurring regression on these duplicated strings — earlier fixes were #9868 and #9897, and the loc bot clobbered them again.
Fix
Restored the pre-#9912 translated
.xlffiles (all 13 languages):Only
<target>values changed (Englishstate="new"→ the previously approved translationsstate="translated"). No.resxchange, and every<source>/ unit ID is untouched.Verification
.resxis byte-identical to Localized file check-in by OneLocBuild Task: Build definition ID 1218: Build ID 3021447 #9912's parent, so the restored.xlfare source-in-sync..resx: 0 mismatches (IDs +<source>text). The XLIFF build check (XliffTasks) only validates IDs/source, not target state, so the build stays green.Note
The underlying loc-pipeline issue (OneLocBuild repeatedly resetting these strings to
state="new") is infrastructure-level and worth a separate follow-up so it stops recurring.