Display an informational Pylance prompt for existing users - #16069
Merged
Kim-Adeline Miguel (kimadeline) merged 24 commits intoMay 4, 2021
Merged
Conversation
added 8 commits
April 27, 2021 19:06
Kim-Adeline Miguel (kimadeline)
marked this pull request as ready for review
April 28, 2021 16:38
Kim-Adeline Miguel (kimadeline)
requested a review
from Jake Bailey (jakebailey)
April 28, 2021 16:38
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Paula (paulacamargo25)
April 28, 2021 16:38
Kim-Adeline Miguel (kimadeline)
changed the title
Author
|
Let me close this and re-create this PR against |
added 3 commits
April 29, 2021 16:13
added 3 commits
May 3, 2021 15:10
Jake Bailey (jakebailey)
approved these changes
May 3, 2021
Kim-Adeline Miguel (kimadeline)
requested review from
Jake Bailey (jakebailey),
Kartik Raj (karrtikr) and
Paula (paulacamargo25)
May 4, 2021 19:48
Author
|
lol sorry Jake Bailey (@jakebailey) didn't mean to re-request yours |
Karthik Nadig (karthiknadig)
approved these changes
May 4, 2021
Paula (paulacamargo25)
approved these changes
May 4, 2021
Kartik Raj (karrtikr)
approved these changes
May 4, 2021
Kim-Adeline Miguel (kimadeline)
merged commit May 4, 2021
619325b
into
microsoft:default-language-server
Kim-Adeline Miguel (kimadeline)
added a commit
that referenced
this pull request
May 5, 2021
* Bundle Pylance as part of an extension pack (not a hard dependency) (#16077) * extension pack * Undo package.json change * Add extension pack link at build time * Forgot to update all names * Update readme + license at build time (#16134) * Add license update * Update package.json description * Update readme * Add news file * Update header wording * let -> const * Wording * Consistenly use VS Code long form * Display an informational Pylance prompt for existing users (#16069) * Export extension version memento * Add localization strings * Add prompt check * Add to the list of things triggering on activation * Add tests * Rename file * Remove unsupported newlines * Fix localization + re-add newlines * Change to be a non-blocking diagnostic check * Change localization key * Update memento on close instead of just on ok * Fix localization * Add initialMementoValue handler * Links * Fix tests * Fix tests * Set PYLANCE_PROMPT_MEMENTO to false * Remove unused line * Set to true directly * Remove extra updateMemento calls * I can't read * Period * Run in foreground * Add handling test * Remove extension pack category (#16149) Co-authored-by: Jake Bailey <5341706+jakebailey@users.noreply.github.com>
This was referenced May 5, 2021
Merged
Member
|
[ @rushfan0 I edited your ✉️ ⬆️ to come off as more 😃 and less 😠 ] There is no uninstall button because there is no such API in VS Code (it would actually be a potential security hole if there was such a thing). And the whole reason we are providing this prompt is to give you the opportunity to uninstall Pylance if you don't want it instead of flipping the default without informing you, so this is the best option we have for informing you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For https://github.com/microsoft/vscode-python-internalbacklog/issues/179
Let me know if you can think of a more appropriate location/filename.
cc Savannah Ostrowski (@savannahostrowski) Luciana Abud (@luabud)