Add survey for MPLS usage - #16403
Merged
Merged
Conversation
Jake Bailey (jakebailey)
marked this pull request as ready for review
June 7, 2021 19:39
github-actions
Bot
requested review from
Kartik Raj (karrtikr) and
Paula (paulacamargo25)
June 7, 2021 19:39
Karthik Nadig (karthiknadig)
self-requested a review
June 7, 2021 20:21
Karthik Nadig (karthiknadig)
approved these changes
Jun 7, 2021
Kartik Raj (karrtikr)
left a comment
Kartik Raj (karrtikr)
left a comment
There was a problem hiding this comment.
Should remove updateMemento() in favor of using built in diagnostic command API, LGTM otherwise.
Paula (paulacamargo25)
approved these changes
Jun 7, 2021
Member
Author
|
Working on refactoring to use the commands and ditch the memento, testing is just not fun. |
Member
Author
|
Refactored. This relies on the assumption that |
Member
Author
|
Kartik Raj (@karrtikr) Can you take a look to see if the current state is reasonable? I am not super familiar with this new diagnostic infrastructure. |
Kartik Raj (karrtikr)
approved these changes
Jun 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is modeled on #16069 and the main survey banner.