Add an "enumDescriptions" key to describe all language server options - #16236
Merged
Kim-Adeline Miguel (kimadeline) merged 2 commits intoMay 18, 2021
Merged
Conversation
added 2 commits
May 13, 2021 09:49
Kim-Adeline Miguel (kimadeline)
added
the
skip package*.json
Kim-Adeline Miguel (kimadeline)
marked this pull request as ready for review
May 13, 2021 18:10
github-actions
Bot
requested review from
Karthik Nadig (karthiknadig) and
Paula (paulacamargo25)
May 13, 2021 18:17
Karthik Nadig (karthiknadig)
left a comment
Karthik Nadig (karthiknadig)
left a comment
Member
There was a problem hiding this comment.
Luciana Abud (@luabud) See comments below.
| ], | ||
| "enumDescriptions": [ | ||
| "Automatically select a language server: Pylance if installed and available, otherwise fallback to Jedi.", | ||
| "Use Jedi as a language server.", |
There was a problem hiding this comment.
Should we say that this works for 2.7 and <=3.5 (uses jedi 0.17.*)
| "enumDescriptions": [ | ||
| "Automatically select a language server: Pylance if installed and available, otherwise fallback to Jedi.", | ||
| "Use Jedi as a language server.", | ||
| "Use Jedi behind the Language Server Protocol (LSP) as a language server.", |
There was a problem hiding this comment.
Should we say this works only for 3.6 or greater? (uses newer jedi version)
There was a problem hiding this comment.
Karthik Nadig (@karthiknadig) this looks good to me, I think we should leave the details for what is supported vs not to our docs, if that makes sense
Paula (paulacamargo25)
approved these changes
May 17, 2021
Kim-Adeline Miguel (kimadeline)
requested a review
from Karthik Nadig (karthiknadig)
May 18, 2021 20:31
Karthik Nadig (karthiknadig)
approved these changes
May 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #16141
Preview: