Skip to content

Add an "enumDescriptions" key to describe all language server options #16236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kim-Adeline Miguel (kimadeline) merged 2 commits into from
May 18, 2021
Merged

Add an "enumDescriptions" key to describe all language server options #16236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
297a16b
News entry
May 13, 2021
797e933
Enum descriptions
May 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions news/1 Enhancements/16141.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Add an `enumDescriptions` key under the `python.languageServer` setting to describe all language server options.
8 changes: 8 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1257,6 +1257,14 @@
"Microsoft",
"None"
],
"enumDescriptions": [
"Automatically select a language server: Pylance if installed and available, otherwise fallback to Jedi.",
"Use Jedi as a language server.",

@karthiknadig Karthik Nadig (karthiknadig) May 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say that this works for 2.7 and <=3.5 (uses jedi 0.17.*)

"Use Jedi behind the Language Server Protocol (LSP) as a language server.",

@karthiknadig Karthik Nadig (karthiknadig) May 14, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we say this works only for 3.6 or greater? (uses newer jedi version)

@luabud Luciana Abud (luabud) May 18, 2021

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Karthik Nadig (@karthiknadig) this looks good to me, I think we should leave the details for what is supported vs not to our docs, if that makes sense

"Use Pylance as a language server.",
"Use the Microsoft Python Language Server (MPLS) as a language server. (legacy)",
"Disable language server capabilities."
],
"default": "Default",
"description": "Defines type of the language server.",
"scope": "window"
Expand Down