Ensure we correctly evaluate Unknown type before sending startup telemetry - #17362
Merged
Merged
Conversation
added 2 commits
September 9, 2021 17:31
Kartik Raj (karrtikr)
changed the title
Kartik Raj (karrtikr)
requested review from
Karthik Nadig (karthiknadig) and
Kim-Adeline Miguel (kimadeline)
September 13, 2021 19:53
| return this.locator.resolveEnv(executablePath); | ||
| const resolved = await this.locator.resolveEnv(executablePath); | ||
| if (resolved) { | ||
| this.cache.addEnv(resolved); |
There was a problem hiding this comment.
If user has selected an interpreter which is not discovery cache (maybe a new type of virtual env we do not support), this is useful.
Kim-Adeline Miguel (kimadeline)
approved these changes
Sep 14, 2021
Kartik Raj (karrtikr)
added
verified
Kartik Raj (karrtikr)
added
verified
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #17359
cc Luciana Abud (@luabud)