Allow users to not show 'Install missing Linter' prompt. - #3553
Merged
Derek Keeler (d3r3kk) merged 6 commits intoDec 11, 2018
Conversation
Don Jayamanne (DonJayamanne)
requested changes
Dec 5, 2018
Don Jayamanne (DonJayamanne)
left a comment
Don Jayamanne (DonJayamanne)
left a comment
There was a problem hiding this comment.
This applies only to Pylint
'Do not display' applies across ALL workspaces.
Don Jayamanne (DonJayamanne)
requested changes
Dec 5, 2018
Derek Keeler (d3r3kk)
force-pushed
the
3349_limit_linter_popup
branch
from
December 8, 2018 22:36
095d373 to
844d532
Compare
Author
|
Don Jayamanne (@DonJayamanne) please re-review when you get a moment. |
Don Jayamanne (DonJayamanne)
requested changes
Dec 10, 2018
Fix for microsoft#3349 - Saves persisted value per linter/per workspace
- add test to ensure it only shows for pylint
…pace. - update news
Derek Keeler (d3r3kk)
force-pushed
the
3349_limit_linter_popup
branch
from
December 11, 2018 06:41
cf1d5f7 to
48cfd72
Compare
Don Jayamanne (DonJayamanne)
approved these changes
Dec 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for #3349
Saves persisted value per linter/per workspace
Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
Title summarizes what is changing
Has a news entry file (remember to thank yourself!)
Unit tests & system/integration tests are added/updated
Test plan is updated as appropriatepackage-lock.jsonhas been regenerated by runningnpm install(if dependencies have changed)