fix: rename product executable on macOS - #291948
Merged
Merged
Conversation
Robo (deepak1556)
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR renames the macOS executable from "Electron" to the product's short name (e.g., "Code", "Code - OSS") to better reflect the actual product identity. This change affects various test files, scripts, and build configurations.
Changes:
- Updated comments in test files to reflect the new executable name
- Modified path resolution logic to use
product.nameShortinstead of hardcoded "Electron" - Added backward compatibility for builds version 1.109 and earlier
- Updated shell scripts to dynamically determine the executable name from product.json
- Updated build configuration and gulpfile to set the darwin executable name
- Updated VS Code debug launch configurations to use the correct executable path
Reviewed changes
Copilot reviewed 10 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test/smoke/src/main.ts | Updated comment to reflect new executable name "Code" instead of "Electron" |
| test/mcp/src/application.ts | Updated comment to reflect new executable name "Code" instead of "Electron" |
| test/automation/src/electron.ts | Added version parsing logic and backward compatibility check; updated path resolution to use product.nameShort |
| scripts/test.sh | Modified to read executable name from product.json nameShort property |
| scripts/node-electron.sh | Modified to read executable name from product.json nameShort property |
| scripts/code.sh | Modified to read executable name from product.json nameShort property |
| scripts/code-cli.sh | Modified to read executable name from product.json nameShort property |
| resources/darwin/bin/code.sh | Changed hardcoded "Electron" to @char (@name)@@ placeholder for replacement during build |
| build/lib/electron.ts | Added darwinExecutable configuration property using product.nameShort |
| build/gulpfile.vscode.ts | Added placeholder replacement for @char (@name)@@ with product.nameShort |
| .vscode/launch.json | Updated debug configurations to use "Code - OSS" instead of "Electron" |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Feb 3, 2026
Robo (deepak1556)
marked this pull request as ready for review
February 3, 2026 20:42
Robo (deepak1556)
enabled auto-merge (squash)
February 3, 2026 20:42
Contributor
📬 CODENOTIFYThe following users are being notified based on files changed in this PR: Ladislau Szomoru (@lszomoru)Matched files:
Benjamin Pasero (@bpasero)Matched files:
|
Matt Bierner (mjbvz)
approved these changes
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build https://dev.azure.com/monacotools/Monaco/_build/results?buildId=401530&view=results