build: always repackage electron from oss entry scripts - #292770
Conversation
There was a problem hiding this comment.
Pull request overview
This PR removes the version caching mechanism for Electron packaging to ensure users always get the latest renamed executable. This is a follow-up to PR #291948 which renamed the product executable on macOS.
Changes:
- Removed version checking logic that prevented repackaging when the cached version matched the current version
- Simplified the
mainfunction to always remove and repackage Electron
|
Failing remote smoketests are crashing with this change, looking into it |
|
Ah the issue was that the failing smoketests trigger our prelaunch task which repackage electron, the oss app was repackaged while it was running leading to SIGTRAP in https://github.com/electron/electron/blob/51a9101c3de7794baad9c35cce57adecf9ea3ad3/shell/browser/electron_browser_client.cc#L496-L510 The version check was preventing these unnecessary and harmful redownloads.. |
Robo (deepak1556)
changed the title
68759b0 to
b8a24a7
Compare
Pull request was converted to draft
b8a24a7 to
1b8559a
Compare
|
Turns out the redownload during remote tests was happening because of the test-resolver extension launching Line 15 in 519788f |
)" This reverts commit fef6f5a.
Follow-up to #291948
Users having cached version of
.build/electronwill fail to pick up the renamed executable. Also, the downloads for a version are already cached, it isn't required to cache the packaging.