Skip to content

Add support for removing temporary files#427

Merged
ryfu-msft merged 7 commits into
microsoft:mainfrom
mdanish-kh:cleanUp
Aug 23, 2023
Merged

Add support for removing temporary files#427
ryfu-msft merged 7 commits into
microsoft:mainfrom
mdanish-kh:cleanUp

Conversation

@mdanish-kh

@mdanish-kh mdanish-kh commented Aug 11, 2023

Copy link
Copy Markdown
Contributor

Also added a user setting to control the cleanup process. Chose 7-day interval as the default to be consistent with microsoft/winget-cli#3434


Microsoft Reviewers: codeflow:open?pullrequest=#427

@mdanish-kh mdanish-kh requested review from a team, ryfu-msft and yao-msft and removed request for a team August 11, 2023 19:32
@microsoft-github-policy-service microsoft-github-policy-service Bot added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Aug 11, 2023
Comment thread doc/settings.md

@ryfu-msft ryfu-msft left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super neat addition, just a few comments :)

Comment thread doc/settings.md
Comment thread src/WingetCreateCLI/Common.cs Outdated
@mdanish-kh mdanish-kh requested a review from ryfu-msft August 23, 2023 16:29
@ryfu-msft

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@ryfu-msft ryfu-msft merged commit bc99df6 into microsoft:main Aug 23, 2023
@mdanish-kh mdanish-kh deleted the cleanUp branch August 23, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up log files and installer cache directory

3 participants