Free up additional disk space on GitHub runner#2674
Merged
Conversation
Our releasebundle-ubuntu action occasionally failed for it ran out of disk space. (See https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703 for one such example. This additional build step cleans out binaries that we do not need, such as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of a total of 84 GB).
zhassan-aws
reviewed
Aug 11, 2023
celinval
reviewed
Aug 11, 2023
celinval
left a comment
Contributor
There was a problem hiding this comment.
I was wondering if we should add this new step to the setup action instead, so most of our jobs would benefit from this cleanup.
Member
Author
Done. |
4 tasks
Contributor
|
I agree with @zhassan-aws that this is too aggressive. We shouldn't need 28GB ever, and it's good to have less space than that so we can notice performance regressions in the future. |
Member
Author
I'm now more conservative in what is being removed. |
zhassan-aws
approved these changes
Aug 18, 2023
adpaco
reviewed
Aug 18, 2023
This was referenced Aug 23, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Our releasebundle-ubuntu action occasionally failed for it ran out of disk space. (See
https://github.com/model-checking/kani/actions/runs/5765091278/job/15630375703 for one such example.
This additional build step cleans out binaries that we do not need, such as Haskell, .NET, or Android SDKs. This frees up 28 GB of memory (out of a total of 84 GB).
Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? CI
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.