Free up disk space (again)#2704
Merged
Merged
Conversation
This is to first debug why we aren't actually gaining any space.
feliperodri
approved these changes
Aug 23, 2023
4 tasks
celinval
added a commit
that referenced
this pull request
Aug 23, 2023
Benchcomp CI is now broken due to #2704. The clean up we are performing is a best effort at this point, but it shouldn't fail the regression if it doesn't work.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Actually free up space as when #2674 tried to remove the wrong directories, which went unnoticed for the use of
rm -rf. Also makes it work with the container image, which really is the main reason we wanted this: use bind mounts to remove files from the host file system. Thedfoutput now confirms that we are actually freeing up space.Resolved issues:
n/a
Related RFC:
n/a
Call-outs:
n/a
Testing:
How is this change tested? CI
Is this a refactor change? no
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.