Skip to content

Don't error out if cleanup fails#2708

Merged
celinval merged 2 commits into
model-checking:mainfrom
celinval:issue-xxxx-fix-bench
Aug 23, 2023
Merged

Don't error out if cleanup fails#2708
celinval merged 2 commits into
model-checking:mainfrom
celinval:issue-xxxx-fix-bench

Conversation

@celinval

Copy link
Copy Markdown
Contributor

Description of changes:

Benchcomp CI is now broken due to #2704. The clean up we are performing is a best effort at this point, but it shouldn't fail the regression if it doesn't work.

Resolved issues:

Resolves #ISSUE-NUMBER

Related RFC:

Optional #ISSUE-NUMBER.

Call-outs:

Testing:

  • How is this change tested?

  • Is this a refactor change?

Checklist

  • Each commit message has a non-empty body, explaining why the change was made
  • Methods or procedures are documented
  • Regression or unit tests are included, or existing tests cover the modified code
  • My PR is restricted to a single feature or bugfix

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.

@celinval celinval requested a review from a team as a code owner August 23, 2023 20:54
@celinval celinval added the Z-EndToEndBenchCI Tag a PR to run benchmark CI label Aug 23, 2023
@celinval

Copy link
Copy Markdown
Contributor Author

Running benchmark CI since that's the one we are trying to fix

@adpaco adpaco enabled auto-merge (squash) August 23, 2023 22:15
@celinval celinval disabled auto-merge August 23, 2023 22:47
@celinval celinval enabled auto-merge (squash) August 23, 2023 22:48
@celinval celinval merged commit 5516650 into model-checking:main Aug 23, 2023
@tautschnig

Copy link
Copy Markdown
Member

Just to clarify: this failed the benchcomp task, because said task invokes setup twice, and it's the setup step that performs the cleanup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-EndToEndBenchCI Tag a PR to run benchmark CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants