fix(connect): unifying topology connect options - #1615
Merged
Conversation
Eliminates the DB parameter from the `connect` call in replset and mongos to unify the api with server
daprahamian
force-pushed
the
NODE-1089
branch
from
December 12, 2017 21:52
ddc95a5 to
2edfdd8
Compare
daprahamian
changed the title
daprahamian
changed the title
Contributor
Author
|
Removed WIP, this should be ready for review |
mbroadst
approved these changes
Dec 14, 2017
jlord
approved these changes
Dec 18, 2017
This was referenced Mar 8, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UPDATE: Eliminates the DB parameter from the
connectcall in replsetand mongos to unify the api with server
Would like some discussion on this, as some fix is needed for NODE-1089