Skip to content

fix(connect): unifying topology connect options #1615

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daprahamian merged 1 commit into from
Dec 18, 2017
Merged

fix(connect): unifying topology connect options #1615

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/topologies/mongos.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,7 +209,7 @@ class Mongos extends TopologyBase {
}

// Connect
connect(db, _options, callback) {
connect(_options, callback) {
var self = this;
if ('function' === typeof _options) (callback = _options), (_options = {});
if (_options == null) _options = {};
Expand All @@ -218,7 +218,8 @@ class Mongos extends TopologyBase {
self.s.options = _options;

// Update bufferMaxEntries
self.s.storeOptions.bufferMaxEntries = db.bufferMaxEntries;
self.s.storeOptions.bufferMaxEntries =
typeof _options.bufferMaxEntries === 'number' ? _options.bufferMaxEntries : -1;

// Error handler
var connectErrorHandler = function() {
Expand Down
5 changes: 3 additions & 2 deletions lib/topologies/replset.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@ class ReplSet extends TopologyBase {
}

// Connect method
connect(db, _options, callback) {
connect(_options, callback) {
var self = this;
if ('function' === typeof _options) (callback = _options), (_options = {});
if (_options == null) _options = {};
Expand All @@ -245,7 +245,8 @@ class ReplSet extends TopologyBase {
self.s.options = _options;

// Update bufferMaxEntries
self.s.storeOptions.bufferMaxEntries = db.bufferMaxEntries;
self.s.storeOptions.bufferMaxEntries =
typeof _options.bufferMaxEntries === 'number' ? _options.bufferMaxEntries : -1;

// Actual handler
var errorHandler = function(event) {
Expand Down