Fix some broken links. - #2
Merged
Merged
Conversation
Member
I would just remove that "Additional Reading" section
I need to put the old wiki back online so we can get this missing content - I'd skip these for now because im busy reviewing PRs
These have all been moved to https://github.com/ros-planning/moveit_tutorials/blob/master/doc/pr2_tutorials/ Your other substitutions looks good |
Member
|
I like the fixes you have so far - I'm going to merge this now and it would be great if you could open another PR for the remaining links |
davetcoleman
referenced
this pull request
in davetcoleman/moveit_tutorials
Apr 13, 2018
* updated images with Panda * removing old PR2 images * updating setup assistant tutorial
davetcoleman
pushed a commit
that referenced
this pull request
May 15, 2018
* updated images with Panda * removing old PR2 images * updating setup assistant tutorial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The majority of the links don't work because of links of type http://docs.ros.org/api/ don't exist currently. For a temporary fix, see my other pull request.
Links I was not able to fix because either the target exists no longer or I was unable to find it:
file: doc/ros_visualization/visualization_tutorial.rst
Link http://moveit.ros.org/wiki/PR2/Gazebo/Quick_Start ,
possible link target: http://wiki.ros.org/pr2_simulator/Tutorials/StartingPR2Simulation
file: doc/pr2_tutorials/kinematics/src/doc/kinematics_tutorial.rst
link http://moveit.ros.org/wiki/RobotStateDisplay/C%2B%2B_API
file dec/setup_assistant/setup_assistant_tutorial.rst
link http://moveit.ros.org/wiki/SRDF and http://moveit.ros.org/wiki/URDF
file doc/pr2_tutorials/planning/src/doc/planning_scene_ros_api_tutorial.rst
link https://github.com/ros-planning/moveit_pr2/blob/hydro-devel/moveit_tutorials/planning/launch/planning_scene_ros_api_tutorial.launch
All links pointing to a file in a subdirectory of https://github.com/ros-planning/moveit_pr2/blob/hydro-devel. Files containing such links:
doc/pr2_tutorials/planning/src/doc/perception_configuration.rst
doc/pr2_tutorials/planning/src/doc/motion_planning_api_tutorial.rst
doc/pr2_tutorials/planning/src/doc/move_group_interface_tutorial.rst
doc/pr2_tutorials/planning/src/doc/planning_scene_tutorial.rst
doc/pr2_tutorials/planning/src/doc/planning_scene_ros_api_tutorial.rst
doc/pr2_tutorials/planning/src/doc/planning_pipeline_tutorial.rst
doc/pr2_tutorials/planning/scripts/doc/move_group_python_interface_tutorial.rst